{"thread":{"id":"37895","subject":"[PATCH] sparse: suppress an \"using sizeof on a function\" warning","startedAt":"2014-11-07T13:50:27Z","lastAt":"2014-11-07T21:07:51Z","messageCount":4,"participants":["Ramsay Jones","ockham@raz.or.at","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"251454","messageId":"545CCE23.5080507@ramsay1.demon.co.uk","threadId":"37895","inReplyTo":null,"subject":"[PATCH] sparse: suppress an \"using sizeof on a function\" warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-11-07T13:50:27Z","receivedAt":"2014-11-07T13:50:27Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Commit d57da44b1 (\"imap-send: use libcurl for implementation\",\n06-11-2014) updates the implementation of the imap-send command\nto make use of libcurl's high(er)-level API functions.\n\nIn doing so, this introduces a sparse warning about \"using sizeof\non a function\". In order to suppress the warning, we use the same\nsolution used in commit 9371322a6 (\"sparse: suppress some \"using\nsizeof on a function\" warnings\", 06-10-2013) which solved exactly\nthis problem for the other commands using libcurl.\n\nSigned-off-by: Ramsay Jones \n---\n\nHi Bernhard,\n\nIf you need to re-roll your 'br/imap-send-via-libcurl' branch, could\nyou please squash this into your patch.\n\nThanks!\n\nATB,\nRamsay Jones\n\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex 1ded274..0fc2790 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1930,7 +1930,7 @@ gettext.sp gettext.s gettext.o: GIT-PREFIX\n gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \\\n \t-DGIT_LOCALE_PATH='\"$(localedir_SQ)\"'\n \n-http-push.sp http.sp http-walker.sp remote-curl.sp: SPARSE_FLAGS += \\\n+http-push.sp http.sp http-walker.sp remote-curl.sp imap-send.sp: SPARSE_FLAGS += \\\n \t-DCURL_DISABLE_TYPECHECK\n \n ifdef NO_EXPAT\n-- \n2.1.0\n"},{"id":"251506","messageId":"20141107210150.Horde.XRUyBUv4Cn9UXSUur_a0avA@webmail.domainplanet.at","threadId":"37895","inReplyTo":"545CCE23.5080507@ramsay1.demon.co.uk","subject":"Re: [PATCH] sparse: suppress an \"using sizeof on a function\" warning","fromName":"","fromEmail":"ockham@raz.or.at","sentAt":"2014-11-07T20:01:50Z","receivedAt":"2014-11-07T20:01:50Z","isPatch":true,"sender":{"key":"ockham@raz.or.at","avatar":"https://avatars.githubusercontent.com/u/96308?v=4"},"body":"Zitat von Ramsay Jones :\n\n> Commit d57da44b1 (\"imap-send: use libcurl for implementation\",\n> 06-11-2014) updates the implementation of the imap-send command\n> to make use of libcurl's high(er)-level API functions.\n>\n> In doing so, this introduces a sparse warning about \"using sizeof\n> on a function\". In order to suppress the warning, we use the same\n> solution used in commit 9371322a6 (\"sparse: suppress some \"using\n> sizeof on a function\" warnings\", 06-10-2013) which solved exactly\n> this problem for the other commands using libcurl.\n>\n> Signed-off-by: Ramsay Jones \n> ---\n>\n> Hi Bernhard,\n>\n> If you need to re-roll your 'br/imap-send-via-libcurl' branch, could\n> you please squash this into your patch.\n>\n> Thanks!\n\nHi Ramsay,\n\nand thanks for your fix! TBH, I didn't even notice that my patch had \nalready been committed and instead posted a refined version earlier \ntoday [1] (which unfortunately didn't contain your fix, either).\n\nNot sure how to proceed. Maybe Junio can enlighten?\n\nRegards\nBernhard\n\n[1] http://www.mail-archive.com/git@vger.kernel.org/msg60576.html\n\n> ATB,\n> Ramsay Jones\n>\n> Makefile | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Makefile b/Makefile\n> index 1ded274..0fc2790 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1930,7 +1930,7 @@ gettext.sp gettext.s gettext.o: GIT-PREFIX\n> gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \\\n> \t-DGIT_LOCALE_PATH='\"$(localedir_SQ)\"'\n>\n> -http-push.sp http.sp http-walker.sp remote-curl.sp: SPARSE_FLAGS += \\\n> +http-push.sp http.sp http-walker.sp remote-curl.sp imap-send.sp: \n> SPARSE_FLAGS += \\\n> \t-DCURL_DISABLE_TYPECHECK\n>\n> ifdef NO_EXPAT\n> --\n> 2.1.0\n"},{"id":"251507","messageId":"xmqq4muag4du.fsf@gitster.dls.corp.google.com","threadId":"37895","inReplyTo":"20141107210150.Horde.XRUyBUv4Cn9UXSUur_a0avA@webmail.domainplanet.at","subject":"Re: [PATCH] sparse: suppress an \"using sizeof on a function\" warning","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-11-07T20:08:45Z","receivedAt":"2014-11-07T20:08:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"ockham@raz.or.at writes:\n\n> Hi Ramsay,\n>\n> and thanks for your fix! TBH, I didn't even notice that my patch had\n> already been committed and instead posted a refined version earlier\n> today [1] (which unfortunately didn't contain your fix, either).\n>\n> Not sure how to proceed. Maybe Junio can enlighten?\n\nThere is no \"already committed\" ;-)\n\nYour patch is merely queued on 'pu' (proposed updates), which we all\nexpect to be rerolled. You can just reroll another round, but you\nmight want to wait a bit to see if there are more issues spotted by\nother people before doing so.\n"},{"id":"251518","messageId":"20141107220751.Horde.o8yUBEv4Cn9UXTSnElF0bLA@webmail.domainplanet.at","threadId":"37895","inReplyTo":"xmqq4muag4du.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] sparse: suppress an \"using sizeof on a function\" warning","fromName":"","fromEmail":"ockham@raz.or.at","sentAt":"2014-11-07T21:07:51Z","receivedAt":"2014-11-07T21:07:51Z","isPatch":true,"sender":{"key":"ockham@raz.or.at","avatar":"https://avatars.githubusercontent.com/u/96308?v=4"},"body":"Zitat von Junio C Hamano :\n\n> Your patch is merely queued on 'pu' (proposed updates), which we all\n> expect to be rerolled. You can just reroll another round, but you\n> might want to wait a bit to see if there are more issues spotted by\n> other people before doing so.\n\nOkay, I clearly need to acquaint myself some more with this project's \nreview process.\n\nOne more question though I couldn't find answered in \nDocumentation/SubmittingPatches: When squashing Ramsay's commit into \nmine,\na) do I just keep the commit messages concatenated to each other, or\nb) do I reword his to fit in better with mine, and put the \nSigned-off-by lines at the very end?\nc) ?\n\nBernhard\n"}]}