git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sparse: suppress an "using sizeof on a function" warning

From
ockham@raz.or.at <ockham@raz.or.at>
Date
Nov 7, 2014, 21:07 UTC
Message-ID
<20141107220751.Horde.o8yUBEv4Cn9UXTSnElF0bLA@webmail.domainplanet.at>
In-Reply-To
<xmqq4muag4du.fsf@gitster.dls.corp.google.com>
Zitat von Junio C Hamano <gitster@pobox.com>:
> Your patch is merely queued on 'pu' (proposed updates), which we all
> expect to be rerolled.  You can just reroll another round, but you
> might want to wait a bit to see if there are more issues spotted by
> other people before doing so.

Okay, I clearly need to acquaint myself some more with this project's review process.

One more question though I couldn't find answered in Documentation/SubmittingPatches: When squashing Ramsay's commit into mine, a) do I just keep the commit messages concatenated to each other, or b) do I reword his to fit in better with mine, and put the Signed-off-by lines at the very end? c) ?

Bernhard
Previous: Junio C Hamano
Message 4 of 4 in “sparse: suppress an "using sizeof on a function" warning”
  1. sparse: suppress an "using sizeof on a function" warningRamsay Jones, Nov 7, 2014
  2. ockham@raz.or.atNov 7, 2014
  3. Junio C HamanoNov 7, 2014
  4. ockham@raz.or.atNov 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.