Re: [PATCH] sparse: suppress an "using sizeof on a function" warning

From: ockham@raz.or.at <ockham@raz.or.at>
Date: Nov 7, 2014, 20:01 UTC
Message-ID: <20141107210150.Horde.XRUyBUv4Cn9UXSUur_a0avA@webmail.domainplanet.at>
In-Reply-To: <545CCE23.5080507@ramsay1.demon.co.uk>

Zitat von Ramsay Jones <ramsay@ramsay1.demon.co.uk>:

Show 19 quoted lines

> Commit d57da44b1 ("imap-send: use libcurl for implementation",
> 06-11-2014) updates the implementation of the imap-send command
> to make use of libcurl's high(er)-level API functions.
>
> In doing so, this introduces a sparse warning about "using sizeof
> on a function". In order to suppress the warning, we use the same
> solution used in commit 9371322a6 ("sparse: suppress some "using
> sizeof on a function" warnings", 06-10-2013) which solved exactly
> this problem for the other commands using libcurl.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Bernhard,
>
> If you need to re-roll your 'br/imap-send-via-libcurl' branch, could
> you please squash this into your patch.
>
> Thanks!

Hi Ramsay,

and thanks for your fix! TBH, I didn't even notice that my patch had already been committed and instead posted a refined version earlier today [1] (which unfortunately didn't contain your fix, either).

Not sure how to proceed. Maybe Junio can enlighten?

Regards Bernhard

[1] http://www.mail-archive.com/git@vger.kernel.org/msg60576.html

Show 22 quoted lines

> ATB,
> Ramsay Jones
>
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 1ded274..0fc2790 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1930,7 +1930,7 @@ gettext.sp gettext.s gettext.o: GIT-PREFIX
>  gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \
>  	-DGIT_LOCALE_PATH='"$(localedir_SQ)"'
>
> -http-push.sp http.sp http-walker.sp remote-curl.sp: SPARSE_FLAGS += \
> +http-push.sp http.sp http-walker.sp remote-curl.sp imap-send.sp:  
> SPARSE_FLAGS += \
>  	-DCURL_DISABLE_TYPECHECK
>
>  ifdef NO_EXPAT
> --
> 2.1.0