threads / patch / 35586

patchfor-each-ref: remove unused variable

Subject: [PATCH] for-each-ref: remove unused variable

## tl;dr

2 messages between Dec 30, 2013 and Dec 30, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramkumar Ramachandra· Dec 30, 2013, 16:28 UTC · lore
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 builtin/for-each-ref.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Show changes to builtin/for-each-ref.c +1 −2
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 6551e7b..51798b4 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -92,7 +92,7 @@ static struct {
  */
 static const char **used_atom;
 static cmp_type *used_atom_type;
-static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref;
+static int used_atom_cnt, need_tagged, need_symref;
 static int need_color_reset_at_eol;
 
 /*
@@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
 
 	if (!sort)
 		sort = default_sort();
-	sort_atom_limit = used_atom_cnt;
 
 	/* for warn_ambiguous_refs */
 	git_config(git_default_config, NULL);
-- 
1.8.5.2.227.g53f3478
Junio C Hamano· Dec 30, 2013, 20:22 UTC · re: Ramkumar Ramachandra · lore

Re: [PATCH] for-each-ref: remove unused variable

Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---

Interesting. As far as I can tell, no code ever used this symbol since the command was introduced at 9f613ddd (Add git-for-each-ref: helper for language bindings, 2006-09-15).

Show 24 quoted lines
>  builtin/for-each-ref.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
> index 6551e7b..51798b4 100644
> --- a/builtin/for-each-ref.c
> +++ b/builtin/for-each-ref.c
> @@ -92,7 +92,7 @@ static struct {
>   */
>  static const char **used_atom;
>  static cmp_type *used_atom_type;
> -static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref;
> +static int used_atom_cnt, need_tagged, need_symref;
>  static int need_color_reset_at_eol;
>  
>  /*
> @@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
>  
>  	if (!sort)
>  		sort = default_sort();
> -	sort_atom_limit = used_atom_cnt;
>  
>  	/* for warn_ambiguous_refs */
>  	git_config(git_default_config, NULL);

← back to recent threads