Re: [PATCH] for-each-ref: remove unused variable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 30, 2013, 20:22 UTC
- Message-ID
- <xmqqtxdqqebp.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1388420935-14030-1-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> > ---
Interesting. As far as I can tell, no code ever used this symbol since the command was introduced at 9f613ddd (Add git-for-each-ref: helper for language bindings, 2006-09-15).
Show 24 quoted lines
> builtin/for-each-ref.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
> index 6551e7b..51798b4 100644
> --- a/builtin/for-each-ref.c
> +++ b/builtin/for-each-ref.c
> @@ -92,7 +92,7 @@ static struct {
> */
> static const char **used_atom;
> static cmp_type *used_atom_type;
> -static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref;
> +static int used_atom_cnt, need_tagged, need_symref;
> static int need_color_reset_at_eol;
>
> /*
> @@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
>
> if (!sort)
> sort = default_sort();
> - sort_atom_limit = used_atom_cnt;
>
> /* for warn_ambiguous_refs */
> git_config(git_default_config, NULL);