# [PATCH] for-each-ref: remove unused variable 2 messages from 2013-12-30 to 2013-12-30. Participants: Ramkumar Ramachandra, Junio C Hamano. Thread: https://gitlist.dev/t/35586 ## Ramkumar Ramachandra, 2013-12-30 16:28 Subject: [PATCH] for-each-ref: remove unused variable Message-ID: <1388420935-14030-1-git-send-email-artagnon@gmail.com> URL: https://gitlist.dev/e/1388420935-14030-1-git-send-email-artagnon%40gmail.com ``` Signed-off-by: Ramkumar Ramachandra --- builtin/for-each-ref.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c index 6551e7b..51798b4 100644 --- a/builtin/for-each-ref.c +++ b/builtin/for-each-ref.c @@ -92,7 +92,7 @@ static struct { */ static const char **used_atom; static cmp_type *used_atom_type; -static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref; +static int used_atom_cnt, need_tagged, need_symref; static int need_color_reset_at_eol; /* @@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) if (!sort) sort = default_sort(); - sort_atom_limit = used_atom_cnt; /* for warn_ambiguous_refs */ git_config(git_default_config, NULL); -- 1.8.5.2.227.g53f3478 ``` ## Junio C Hamano, 2013-12-30 20:22 Subject: Re: [PATCH] for-each-ref: remove unused variable Message-ID: URL: https://gitlist.dev/e/xmqqtxdqqebp.fsf%40gitster.dls.corp.google.com In-Reply-To: <1388420935-14030-1-git-send-email-artagnon@gmail.com> ``` Ramkumar Ramachandra writes: > Signed-off-by: Ramkumar Ramachandra > --- Interesting. As far as I can tell, no code ever used this symbol since the command was introduced at 9f613ddd (Add git-for-each-ref: helper for language bindings, 2006-09-15). > builtin/for-each-ref.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c > index 6551e7b..51798b4 100644 > --- a/builtin/for-each-ref.c > +++ b/builtin/for-each-ref.c > @@ -92,7 +92,7 @@ static struct { > */ > static const char **used_atom; > static cmp_type *used_atom_type; > -static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref; > +static int used_atom_cnt, need_tagged, need_symref; > static int need_color_reset_at_eol; > > /* > @@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) > > if (!sort) > sort = default_sort(); > - sort_atom_limit = used_atom_cnt; > > /* for warn_ambiguous_refs */ > git_config(git_default_config, NULL); ```