{"thread":{"id":"35586","subject":"[PATCH] for-each-ref: remove unused variable","startedAt":"2013-12-30T16:28:55Z","lastAt":"2013-12-30T20:22:18Z","messageCount":2,"participants":["Ramkumar Ramachandra","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"232512","messageId":"1388420935-14030-1-git-send-email-artagnon@gmail.com","threadId":"35586","inReplyTo":null,"subject":"[PATCH] for-each-ref: remove unused variable","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-12-30T16:28:55Z","receivedAt":"2013-12-30T16:28:55Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n builtin/for-each-ref.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c\nindex 6551e7b..51798b4 100644\n--- a/builtin/for-each-ref.c\n+++ b/builtin/for-each-ref.c\n@@ -92,7 +92,7 @@ static struct {\n  */\n static const char **used_atom;\n static cmp_type *used_atom_type;\n-static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref;\n+static int used_atom_cnt, need_tagged, need_symref;\n static int need_color_reset_at_eol;\n \n /*\n@@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)\n \n \tif (!sort)\n \t\tsort = default_sort();\n-\tsort_atom_limit = used_atom_cnt;\n \n \t/* for warn_ambiguous_refs */\n \tgit_config(git_default_config, NULL);\n-- \n1.8.5.2.227.g53f3478\n"},{"id":"232526","messageId":"xmqqtxdqqebp.fsf@gitster.dls.corp.google.com","threadId":"35586","inReplyTo":"1388420935-14030-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH] for-each-ref: remove unused variable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-12-30T20:22:18Z","receivedAt":"2013-12-30T20:22:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramkumar Ramachandra <artagnon@gmail.com> writes:\n\n> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n> ---\n\nInteresting. As far as I can tell, no code ever used this symbol\nsince the command was introduced at 9f613ddd (Add git-for-each-ref:\nhelper for language bindings, 2006-09-15).\n\n>  builtin/for-each-ref.c | 3 +--\n>  1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c\n> index 6551e7b..51798b4 100644\n> --- a/builtin/for-each-ref.c\n> +++ b/builtin/for-each-ref.c\n> @@ -92,7 +92,7 @@ static struct {\n>   */\n>  static const char **used_atom;\n>  static cmp_type *used_atom_type;\n> -static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref;\n> +static int used_atom_cnt, need_tagged, need_symref;\n>  static int need_color_reset_at_eol;\n>  \n>  /*\n> @@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)\n>  \n>  \tif (!sort)\n>  \t\tsort = default_sort();\n> -\tsort_atom_limit = used_atom_cnt;\n>  \n>  \t/* for warn_ambiguous_refs */\n>  \tgit_config(git_default_config, NULL);\n"}]}