On Mon, Feb 27, 2006 at 11:56:29PM -0500, Pavel Roskin wrote:
Show 5 quoted lines
> From: Pavel Roskin <proski@gnu.org> > > Select the text color based on whether the entry in highlighted. Use > standard font. > ---
Applied
-aneesh
threads / patch / 3488
patch, 2 partsRe: [PATCH 1/2] Use solid text for refs in gitview
Subject: Re: [PATCH 1/2] Use solid text for refs in gitview
Re: [PATCH 2/2] Don't use excessive non-standard border width
On Mon, Feb 27, 2006 at 11:56:31PM -0500, Pavel Roskin wrote:
Show 28 quoted lines
> From: Pavel Roskin <proski@gnu.org> > > > --- > > contrib/gitview/gitview | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview > index aded7ed..00cb8ee 100755 > --- a/contrib/gitview/gitview > +++ b/contrib/gitview/gitview > @@ -492,7 +492,6 @@ class GitView: > def construct_top(self): > """Construct the top-half of the window.""" > vbox = gtk.VBox(spacing=6) > - vbox.set_border_width(12) > vbox.show() > > menu_bar = gtk.MenuBar() > @@ -574,7 +573,6 @@ class GitView: > def construct_bottom(self): > """Construct the bottom half of the window.""" > vbox = gtk.VBox(False, spacing=6) > - vbox.set_border_width(12) > (width, height) = self.window.get_size() > vbox.set_size_request(width, int(height / 2.5)) > vbox.show()
I am not sure about this. I guess it looks much better with a border.
Not applied.
-aneesh
Re: [PATCH 2/2] Don't use excessive non-standard border width
Hi, Aneesh!
On Tue, 2006-02-28 at 10:46 +0530, Aneesh Kumar K.V wrote:
> I am not sure about this. I guess it looks much better with a border. > > Not applied.
I think what really annoyed me was the menu with lone "Help" on the right hand side, and excessive borders only made it look worse. Maybe the border should not be used on the menu? It looks wrong to me that the menu is appended to the top pane rather than to the whole window.
-- Regards, Pavel Roskin
Re: [PATCH 2/2] Don't use excessive non-standard border width
On Tue, Feb 28, 2006 at 12:35:31AM -0500, Pavel Roskin wrote:
Show 12 quoted lines
> Hi, Aneesh! > > On Tue, 2006-02-28 at 10:46 +0530, Aneesh Kumar K.V wrote: > > I am not sure about this. I guess it looks much better with a border. > > > > Not applied. > > I think what really annoyed me was the menu with lone "Help" on the > right hand side, and excessive borders only made it look worse. Maybe > the border should not be used on the menu? It looks wrong to me that > the menu is appended to the top pane rather than to the whole window. >
how about this
Show changes to contrib/gitview/gitview +14 −11
diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview index aded7ed..e57c53b 100755 --- a/contrib/gitview/gitview +++ b/contrib/gitview/gitview @@ -482,19 +482,10 @@ class GitView: def construct(self): """Construct the window contents.""" + vbox = gtk.VBox() paned = gtk.VPaned() paned.pack1(self.construct_top(), resize=False, shrink=True) paned.pack2(self.construct_bottom(), resize=False, shrink=True) - self.window.add(paned) - paned.show() - - - def construct_top(self): - """Construct the top-half of the window.""" - vbox = gtk.VBox(spacing=6) - vbox.set_border_width(12) - vbox.show() - menu_bar = gtk.MenuBar() menu_bar.set_pack_direction(gtk.PACK_DIRECTION_RTL) help_menu = gtk.MenuItem("Help") @@ -506,8 +497,20 @@ class GitView: help_menu.set_submenu(menu) help_menu.show() menu_bar.append(help_menu) - vbox.pack_start(menu_bar, False, False, 2) menu_bar.show() + vbox.pack_start(menu_bar, False, False, 2) + vbox.pack_start(paned, True, True, 2) + self.window.add(vbox) + paned.show() + vbox.show() + + + def construct_top(self): + """Construct the top-half of the window.""" + vbox = gtk.VBox(spacing=6) + vbox.set_border_width(12) + vbox.show() + scrollwin = gtk.ScrolledWindow() scrollwin.set_policy(gtk.POLICY_NEVER, gtk.POLICY_AUTOMATIC)