git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Don't use excessive non-standard border width

From
AKAneesh Kumar K.V <aneesh.kumar@hp.com>
Date
Feb 28, 2006, 05:16 UTC
Message-ID
<20060228051611.GB5934@satan.india.hp.com>
In-Reply-To
<20060228045631.21880.27670.stgit@dv.roinet.com>
On Mon, Feb 27, 2006 at 11:56:31PM -0500, Pavel Roskin wrote:
Show 28 quoted lines
> From: Pavel Roskin <proski@gnu.org>
> 
> 
> ---
> 
>  contrib/gitview/gitview |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview
> index aded7ed..00cb8ee 100755
> --- a/contrib/gitview/gitview
> +++ b/contrib/gitview/gitview
> @@ -492,7 +492,6 @@ class GitView:
>  	def construct_top(self):
>  		"""Construct the top-half of the window."""
>  		vbox = gtk.VBox(spacing=6)
> -		vbox.set_border_width(12)
>  		vbox.show()
>  
>  		menu_bar = gtk.MenuBar()
> @@ -574,7 +573,6 @@ class GitView:
>  	def construct_bottom(self):
>  		"""Construct the bottom half of the window."""
>  		vbox = gtk.VBox(False, spacing=6)
> -		vbox.set_border_width(12)
>  		(width, height) = self.window.get_size()
>  		vbox.set_size_request(width, int(height / 2.5))
>  		vbox.show()
I am not sure about this. I guess it looks much better with a border.
Not applied.
-aneesh
Previous: Aneesh Kumar K.VNext: Pavel Roskin
Message 2 of 4 in “Re: [PATCH 1/2] Use solid text for refs in gitview”
  1. Aneesh Kumar K.VFeb 28, 2006
  2. Aneesh Kumar K.VFeb 28, 2006
  3. Pavel RoskinFeb 28, 2006
  4. Aneesh Kumar K.VFeb 28, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.