{"thread":{"id":"3488","subject":"Re: [PATCH 1/2] Use solid text for refs in gitview","startedAt":"2006-02-28T05:15:36Z","lastAt":"2006-02-28T05:53:00Z","messageCount":4,"participants":["Aneesh Kumar K.V","Pavel Roskin"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"16883","messageId":"20060228051536.GA5934@satan.india.hp.com","threadId":"3488","inReplyTo":"20060228045629.21880.19007.stgit@dv.roinet.com","subject":"Re: [PATCH 1/2] Use solid text for refs in gitview","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@hp.com","sentAt":"2006-02-28T05:15:36Z","receivedAt":"2006-02-28T05:15:36Z","isPatch":true,"sender":{"key":"aneesh.kumar@hp.com","avatar":null},"body":"On Mon, Feb 27, 2006 at 11:56:29PM -0500, Pavel Roskin wrote:\n> From: Pavel Roskin <proski@gnu.org>\n> \n> Select the text color based on whether the entry in highlighted.  Use\n> standard font.\n> ---\n\nApplied\n\n-aneesh\n"},{"id":"16884","messageId":"20060228051611.GB5934@satan.india.hp.com","threadId":"3488","inReplyTo":"20060228045631.21880.27670.stgit@dv.roinet.com","subject":"Re: [PATCH 2/2] Don't use excessive non-standard border width","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@hp.com","sentAt":"2006-02-28T05:16:11Z","receivedAt":"2006-02-28T05:16:11Z","isPatch":true,"sender":{"key":"aneesh.kumar@hp.com","avatar":null},"body":"On Mon, Feb 27, 2006 at 11:56:31PM -0500, Pavel Roskin wrote:\n> From: Pavel Roskin <proski@gnu.org>\n> \n> \n> ---\n> \n>  contrib/gitview/gitview |    2 --\n>  1 files changed, 0 insertions(+), 2 deletions(-)\n> \n> diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview\n> index aded7ed..00cb8ee 100755\n> --- a/contrib/gitview/gitview\n> +++ b/contrib/gitview/gitview\n> @@ -492,7 +492,6 @@ class GitView:\n>  \tdef construct_top(self):\n>  \t\t\"\"\"Construct the top-half of the window.\"\"\"\n>  \t\tvbox = gtk.VBox(spacing=6)\n> -\t\tvbox.set_border_width(12)\n>  \t\tvbox.show()\n>  \n>  \t\tmenu_bar = gtk.MenuBar()\n> @@ -574,7 +573,6 @@ class GitView:\n>  \tdef construct_bottom(self):\n>  \t\t\"\"\"Construct the bottom half of the window.\"\"\"\n>  \t\tvbox = gtk.VBox(False, spacing=6)\n> -\t\tvbox.set_border_width(12)\n>  \t\t(width, height) = self.window.get_size()\n>  \t\tvbox.set_size_request(width, int(height / 2.5))\n>  \t\tvbox.show()\n\n\nI am not sure about this. I guess it looks much better with a border.\n\nNot applied.\n\n-aneesh\n"},{"id":"16886","messageId":"1141104931.22029.5.camel@dv","threadId":"3488","inReplyTo":"20060228051611.GB5934@satan.india.hp.com","subject":"Re: [PATCH 2/2] Don't use excessive non-standard border width","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-02-28T05:35:31Z","receivedAt":"2006-02-28T05:35:31Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hi, Aneesh!\n\nOn Tue, 2006-02-28 at 10:46 +0530, Aneesh Kumar K.V wrote:\n> I am not sure about this. I guess it looks much better with a border.\n> \n> Not applied.\n\nI think what really annoyed me was the menu with lone \"Help\" on the\nright hand side, and excessive borders only made it look worse.  Maybe\nthe border should not be used on the menu?  It looks wrong to me that\nthe menu is appended to the top pane rather than to the whole window.\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"16887","messageId":"20060228055300.GD5934@satan.india.hp.com","threadId":"3488","inReplyTo":"1141104931.22029.5.camel@dv","subject":"Re: [PATCH 2/2] Don't use excessive non-standard border width","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@hp.com","sentAt":"2006-02-28T05:53:00Z","receivedAt":"2006-02-28T05:53:00Z","isPatch":true,"sender":{"key":"aneesh.kumar@hp.com","avatar":null},"body":"On Tue, Feb 28, 2006 at 12:35:31AM -0500, Pavel Roskin wrote:\n> Hi, Aneesh!\n> \n> On Tue, 2006-02-28 at 10:46 +0530, Aneesh Kumar K.V wrote:\n> > I am not sure about this. I guess it looks much better with a border.\n> > \n> > Not applied.\n> \n> I think what really annoyed me was the menu with lone \"Help\" on the\n> right hand side, and excessive borders only made it look worse.  Maybe\n> the border should not be used on the menu?  It looks wrong to me that\n> the menu is appended to the top pane rather than to the whole window.\n> \n\nhow about this\n\ndiff --git a/contrib/gitview/gitview b/contrib/gitview/gitview\nindex aded7ed..e57c53b 100755\n--- a/contrib/gitview/gitview\n+++ b/contrib/gitview/gitview\n@@ -482,19 +482,10 @@ class GitView:\n \n \tdef construct(self):\n \t\t\"\"\"Construct the window contents.\"\"\"\n+\t\tvbox = gtk.VBox()\n \t\tpaned = gtk.VPaned()\n \t\tpaned.pack1(self.construct_top(), resize=False, shrink=True)\n \t\tpaned.pack2(self.construct_bottom(), resize=False, shrink=True)\n-\t\tself.window.add(paned)\n-\t\tpaned.show()\n-\n-\n-\tdef construct_top(self):\n-\t\t\"\"\"Construct the top-half of the window.\"\"\"\n-\t\tvbox = gtk.VBox(spacing=6)\n-\t\tvbox.set_border_width(12)\n-\t\tvbox.show()\n-\n \t\tmenu_bar = gtk.MenuBar()\n \t\tmenu_bar.set_pack_direction(gtk.PACK_DIRECTION_RTL)\n \t\thelp_menu = gtk.MenuItem(\"Help\")\n@@ -506,8 +497,20 @@ class GitView:\n \t\thelp_menu.set_submenu(menu)\n \t\thelp_menu.show()\n \t\tmenu_bar.append(help_menu)\n-\t\tvbox.pack_start(menu_bar, False, False, 2)\n \t\tmenu_bar.show()\n+\t\tvbox.pack_start(menu_bar, False, False, 2)\n+\t\tvbox.pack_start(paned, True, True, 2)\n+\t\tself.window.add(vbox)\n+\t\tpaned.show()\n+\t\tvbox.show()\n+\n+\n+\tdef construct_top(self):\n+\t\t\"\"\"Construct the top-half of the window.\"\"\"\n+\t\tvbox = gtk.VBox(spacing=6)\n+\t\tvbox.set_border_width(12)\n+\t\tvbox.show()\n+\n \n \t\tscrollwin = gtk.ScrolledWindow()\n \t\tscrollwin.set_policy(gtk.POLICY_NEVER, gtk.POLICY_AUTOMATIC)\n"}]}