Re: [PATCH 2/2] Don't use excessive non-standard border width
On Tue, Feb 28, 2006 at 12:35:31AM -0500, Pavel Roskin wrote:
Show 12 quoted lines
> Hi, Aneesh!
>
> On Tue, 2006-02-28 at 10:46 +0530, Aneesh Kumar K.V wrote:
> > I am not sure about this. I guess it looks much better with a border.
> >
> > Not applied.
>
> I think what really annoyed me was the menu with lone "Help" on the
> right hand side, and excessive borders only made it look worse. Maybe
> the border should not be used on the menu? It looks wrong to me that
> the menu is appended to the top pane rather than to the whole window.
>
diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview
index aded7ed..e57c53b 100755
--- a/contrib/gitview/gitview
+++ b/contrib/gitview/gitview
@@ -482,19 +482,10 @@ class GitView:
def construct(self):
"""Construct the window contents."""
+ vbox = gtk.VBox()
paned = gtk.VPaned()
paned.pack1(self.construct_top(), resize=False, shrink=True)
paned.pack2(self.construct_bottom(), resize=False, shrink=True)
- self.window.add(paned)
- paned.show()
-
-
- def construct_top(self):
- """Construct the top-half of the window."""
- vbox = gtk.VBox(spacing=6)
- vbox.set_border_width(12)
- vbox.show()
-
menu_bar = gtk.MenuBar()
menu_bar.set_pack_direction(gtk.PACK_DIRECTION_RTL)
help_menu = gtk.MenuItem("Help")
@@ -506,8 +497,20 @@ class GitView:
help_menu.set_submenu(menu)
help_menu.show()
menu_bar.append(help_menu)
- vbox.pack_start(menu_bar, False, False, 2)
menu_bar.show()
+ vbox.pack_start(menu_bar, False, False, 2)
+ vbox.pack_start(paned, True, True, 2)
+ self.window.add(vbox)
+ paned.show()
+ vbox.show()
+
+
+ def construct_top(self):
+ """Construct the top-half of the window."""
+ vbox = gtk.VBox(spacing=6)
+ vbox.set_border_width(12)
+ vbox.show()
+
scrollwin = gtk.ScrolledWindow()
scrollwin.set_policy(gtk.POLICY_NEVER, gtk.POLICY_AUTOMATIC)