{"thread":{"id":"33607","subject":"[PATCH] t9501: Do not use export X=Y","startedAt":"2013-04-25T18:49:00Z","lastAt":"2013-04-26T18:14:41Z","messageCount":5,"participants":["Torsten Bögershausen","Junio C Hamano","Rodrigo Campos"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"215473","messageId":"201304252049.00811.tboegi@web.de","threadId":"33607","inReplyTo":null,"subject":"[PATCH] t9501: Do not use export X=Y","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-25T18:49:00Z","receivedAt":"2013-04-25T18:49:00Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Spilt lines like export X=Y into 2 lines:\nX=Y\nexport X\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t9501-gitweb-standalone-http-status.sh | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh\nindex ef86948..d3a5bac 100755\n--- a/t/t9501-gitweb-standalone-http-status.sh\n+++ b/t/t9501-gitweb-standalone-http-status.sh\n@@ -130,7 +130,8 @@ test_expect_success DATE_PARSER 'modification: feed last-modified' '\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=atom;h=master\" &&\n \tgrep \"Status: 200 OK\" gitweb.headers\n@@ -138,7 +139,8 @@ test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: feed if-modified-since (unmodified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=atom;h=master\" &&\n \tgrep \"Status: 304 Not Modified\" gitweb.headers\n@@ -153,7 +155,8 @@ test_expect_success DATE_PARSER 'modification: snapshot last-modified' '\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=snapshot;h=master;sf=tgz\" &&\n \tgrep \"Status: 200 OK\" gitweb.headers\n@@ -161,7 +164,8 @@ test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modif\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (unmodified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=snapshot;h=master;sf=tgz\" &&\n \tgrep \"Status: 304 Not Modified\" gitweb.headers\n@@ -170,7 +174,8 @@ test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: tree snapshot' '\n \tID=`git rev-parse --verify HEAD^{tree}` &&\n-\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=snapshot;h=$ID;sf=tgz\" &&\n \tgrep \"Status: 200 OK\" gitweb.headers &&\n-- \n1.8.2.1.614.g66d7af5\n"},{"id":"215506","messageId":"7va9om2v9z.fsf@alter.siamese.dyndns.org","threadId":"33607","inReplyTo":"201304252049.00811.tboegi@web.de","subject":"Re: [PATCH] t9501: Do not use export X=Y","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-25T20:46:32Z","receivedAt":"2013-04-25T20:46:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Torsten Bögershausen <tboegi@web.de> writes:\n\n> Spilt lines like export X=Y into 2 lines:\n> X=Y\n> export X\n\nThat can be read from the patch text.\n\nIf you are going to spend three lines, please describe why it has to\nbe split; that would help educate developers new to the codebase.\n\nThanks.\n\n> Signed-off-by: Torsten Bögershausen <tboegi@web.de>\n> ---\n>  t/t9501-gitweb-standalone-http-status.sh | 15 ++++++++++-----\n>  1 file changed, 10 insertions(+), 5 deletions(-)\n>\n> diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh\n> index ef86948..d3a5bac 100755\n> --- a/t/t9501-gitweb-standalone-http-status.sh\n> +++ b/t/t9501-gitweb-standalone-http-status.sh\n> @@ -130,7 +130,8 @@ test_expect_success DATE_PARSER 'modification: feed last-modified' '\n>  test_debug 'cat gitweb.headers'\n>  \n>  test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)' '\n> -\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n> +\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n> +\texport HTTP_IF_MODIFIED_SINCE &&\n>  \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n>  \tgitweb_run \"p=.git;a=atom;h=master\" &&\n>  \tgrep \"Status: 200 OK\" gitweb.headers\n> @@ -138,7 +139,8 @@ test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)\n>  test_debug 'cat gitweb.headers'\n>  \n>  test_expect_success DATE_PARSER 'modification: feed if-modified-since (unmodified)' '\n> -\texport HTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n> +\tHTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n> +\texport HTTP_IF_MODIFIED_SINCE &&\n>  \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n>  \tgitweb_run \"p=.git;a=atom;h=master\" &&\n>  \tgrep \"Status: 304 Not Modified\" gitweb.headers\n> @@ -153,7 +155,8 @@ test_expect_success DATE_PARSER 'modification: snapshot last-modified' '\n>  test_debug 'cat gitweb.headers'\n>  \n>  test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modified)' '\n> -\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n> +\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n> +\texport HTTP_IF_MODIFIED_SINCE &&\n>  \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n>  \tgitweb_run \"p=.git;a=snapshot;h=master;sf=tgz\" &&\n>  \tgrep \"Status: 200 OK\" gitweb.headers\n> @@ -161,7 +164,8 @@ test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modif\n>  test_debug 'cat gitweb.headers'\n>  \n>  test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (unmodified)' '\n> -\texport HTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n> +\tHTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n> +\texport HTTP_IF_MODIFIED_SINCE &&\n>  \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n>  \tgitweb_run \"p=.git;a=snapshot;h=master;sf=tgz\" &&\n>  \tgrep \"Status: 304 Not Modified\" gitweb.headers\n> @@ -170,7 +174,8 @@ test_debug 'cat gitweb.headers'\n>  \n>  test_expect_success DATE_PARSER 'modification: tree snapshot' '\n>  \tID=`git rev-parse --verify HEAD^{tree}` &&\n> -\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n> +\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n> +\texport HTTP_IF_MODIFIED_SINCE &&\n>  \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n>  \tgitweb_run \"p=.git;a=snapshot;h=$ID;sf=tgz\" &&\n>  \tgrep \"Status: 200 OK\" gitweb.headers &&\n"},{"id":"215582","messageId":"517A4723.7050309@web.de","threadId":"33607","inReplyTo":"7va9om2v9z.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] t9501: Do not use export X=Y","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-26T09:21:39Z","receivedAt":"2013-04-26T09:21:39Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 2013-04-25 22.46, Junio C Hamano wrote:\n> Torsten Bögershausen <tboegi@web.de> writes:\n> \n>> Spilt lines like export X=Y into 2 lines:\n>> X=Y\n>> export X\n> \n> That can be read from the patch text.\n> \n> If you are going to spend three lines, please describe why it has to\n> be split; that would help educate developers new to the codebase.\n> \nSo true,\nwriting good commit messages is not easy.\nand this was a good example for a bad example\n\nSide questions:\nWhich shells of which OS/distribution do not understand export X=Y?\n"},{"id":"215598","messageId":"7v38udz1da.fsf@alter.siamese.dyndns.org","threadId":"33607","inReplyTo":"517A4723.7050309@web.de","subject":"Re: [PATCH] t9501: Do not use export X=Y","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-26T16:46:09Z","receivedAt":"2013-04-26T16:46:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Torsten Bögershausen <tboegi@web.de> writes:\n\n> On 2013-04-25 22.46, Junio C Hamano wrote:\n>> Torsten Bögershausen <tboegi@web.de> writes:\n>> \n>>> Spilt lines like export X=Y into 2 lines:\n>>> X=Y\n>>> export X\n>> \n>> That can be read from the patch text.\n>> \n>> If you are going to spend three lines, please describe why it has to\n>> be split; that would help educate developers new to the codebase.\n>> \n> So true,\n> writing good commit messages is not easy.\n> and this was a good example for a bad example\n>\n> Side questions:\n> Which shells of which OS/distribution do not understand export X=Y?\n\nI have not met one for quite some time myself. cf.\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/35543/focus=35551\n"},{"id":"215609","messageId":"20130426181441.GF13306@sdfg.com.ar","threadId":"33607","inReplyTo":"7v38udz1da.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] t9501: Do not use export X=Y","fromName":"Rodrigo Campos","fromEmail":"rodrigo@sdfg.com.ar","sentAt":"2013-04-26T18:14:41Z","receivedAt":"2013-04-26T18:14:41Z","isPatch":true,"sender":{"key":"rodrigo@sdfg.com.ar","avatar":null},"body":"On Fri, Apr 26, 2013 at 09:46:09AM -0700, Junio C Hamano wrote:\n> Torsten Bögershausen <tboegi@web.de> writes:\n> \n> > On 2013-04-25 22.46, Junio C Hamano wrote:\n> >> Torsten Bögershausen <tboegi@web.de> writes:\n> >> \n> >>> Spilt lines like export X=Y into 2 lines:\n> >>> X=Y\n> >>> export X\n> >\n> > Side questions:\n> > Which shells of which OS/distribution do not understand export X=Y?\n> \n> I have not met one for quite some time myself. cf.\n\nIt seems Solaris /bin/sh doesn't like it. I don't have a Solaris to test it, but\nthis recent commit of gzip does this change because of Solaris:\n\nhttp://article.gmane.org/gmane.comp.gnu.gzip.bugs/795\n\n\n\n\n\nThanks a lot,\nRodrigo\n"}]}