threads / patch / 32796

patch, 5 partsFix msvc build

Subject: [PATCH 0/5] Fix msvc build

## tl;dr

8 messages between Jan 31, 2013 and Feb 26, 2013. Diffs are folded; open one to read it.

replies: 7people: 4as markdown or json

Ramsay Jones· Jan 31, 2013, 18:26 UTC · lore

As I mentioned recently, while discussing a cygwin specific patch (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the MSVC build is broken for me.

The first 4 patches fix the MSVC build for me. The final patch is not really related to fixing the build, but it removed some make warnings which were quite irritating ...

Note that I used the Makefile, with the Visual C++ 2008 command line compiler on Windows XP (SP3), to build a vanilla git on MinGW. I'm not subscribed to the msysgit mailing list, nor do I follow the msysgit fork of git, so these patches may conflict with commits in their repository.

HTH

ATB, Ramsay Jones

Ramsay Jones (5):
  msvc: Fix compilation errors caused by poll.h emulation
  msvc: git-daemon: Fix linker "unresolved external" errors
  msvc: Fix build by adding missing symbol defines
  msvc: test-svn-fe: Fix linker "unresolved external" error
  msvc: avoid collisions between "tags" and "TAGS"
 compat/msvc.h                     | 2 ++
 compat/vcbuild/include/sys/poll.h | 1 -
 compat/vcbuild/include/unistd.h   | 3 +++
 config.mak.uname                  | 4 +++-
 git-compat-util.h                 | 3 +++
 test-svn-fe.c                     | 2 +-
 6 files changed, 12 insertions(+), 3 deletions(-)
 delete mode 100644 compat/vcbuild/include/sys/poll.h
-- 
1.8.1
Johannes Schindelin· Jan 31, 2013, 18:57 UTC · re: Ramsay Jones · lore

Re: [PATCH 0/5] Fix msvc build

Hi Ramsay,
On Thu, 31 Jan 2013, Ramsay Jones wrote:
Show 7 quoted lines
> As I mentioned recently, while discussing a cygwin specific patch
> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
> MSVC build is broken for me.
> 
> The first 4 patches fix the MSVC build for me. The final patch is
> not really related to fixing the build, but it removed some make
> warnings which were quite irritating ...
Thanks!
> Note that I used the Makefile, with the Visual C++ 2008 command line
> compiler on Windows XP (SP3), to build a vanilla git on MinGW.  I'm not
> subscribed to the msysgit mailing list, nor do I follow the msysgit fork
> of git, so these patches may conflict with commits in their repository.

Maybe you can Cc: the patch series to msysgit@googlegroups.com nevertheless?

Thanks, Dscho

Junio C Hamano· Jan 31, 2013, 19:28 UTC · re: Johannes Schindelin · lore

Re: [PATCH 0/5] Fix msvc build

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 21 quoted lines
> Hi Ramsay,
>
> On Thu, 31 Jan 2013, Ramsay Jones wrote:
>
>> As I mentioned recently, while discussing a cygwin specific patch
>> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
>> MSVC build is broken for me.
>> 
>> The first 4 patches fix the MSVC build for me. The final patch is
>> not really related to fixing the build, but it removed some make
>> warnings which were quite irritating ...
>
> Thanks!
>
>> Note that I used the Makefile, with the Visual C++ 2008 command line
>> compiler on Windows XP (SP3), to build a vanilla git on MinGW.  I'm not
>> subscribed to the msysgit mailing list, nor do I follow the msysgit fork
>> of git, so these patches may conflict with commits in their repository.
>
> Maybe you can Cc: the patch series to msysgit@googlegroups.com
> nevertheless?

OK. The only thing I can say about these patches is that none of them would affect my boxes would exercise, so I'll wait until I get a final-for-application re-send from mysgit folks, preferrably with their Acked-by: lines.

Thanks.
Junio C Hamano· Feb 25, 2013, 06:54 UTC · re: Ramsay Jones · lore

Re: [PATCH 0/5] Fix msvc build

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 13 quoted lines
> As I mentioned recently, while discussing a cygwin specific patch
> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
> MSVC build is broken for me.
>
> The first 4 patches fix the MSVC build for me. The final patch is
> not really related to fixing the build, but it removed some make
> warnings which were quite irritating ...
>
> Note that I used the Makefile, with the Visual C++ 2008 command
> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.
> I'm not subscribed to the msysgit mailing list, nor do I follow the
> msysgit fork of git, so these patches may conflict with commits in
> their repository.
Did anything further happen to this topic in the Windows land?
Johannes Sixt· Feb 25, 2013, 08:25 UTC · re: Junio C Hamano · lore

Re: [PATCH 0/5] Fix msvc build

Am 2/25/2013 7:54, schrieb Junio C Hamano:
Show 17 quoted lines
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> 
>> As I mentioned recently, while discussing a cygwin specific patch
>> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
>> MSVC build is broken for me.
>>
>> The first 4 patches fix the MSVC build for me. The final patch is
>> not really related to fixing the build, but it removed some make
>> warnings which were quite irritating ...
>>
>> Note that I used the Makefile, with the Visual C++ 2008 command
>> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.
>> I'm not subscribed to the msysgit mailing list, nor do I follow the
>> msysgit fork of git, so these patches may conflict with commits in
>> their repository.
> 
> Did anything further happen to this topic in the Windows land?

I successfully built with MSVC with these patches (but I am not using the result anywhere nor did I attempt to run the test suite).

More importantly, I'm using git on Windows ("MinGW flavor") with these patches in production, so there are no obvious regressions.

Feel free to add my
Tested-by: Johannes Sixt <j6t@kdbg.org>
but if you don't have the patches around, I can resend them.
-- Hannes
Johannes Schindelin· Feb 25, 2013, 19:01 UTC · re: Johannes Sixt · lore

Re: [PATCH 0/5] Fix msvc build

Hi Hannes,
On Mon, 25 Feb 2013, Johannes Sixt wrote:
Show 30 quoted lines
> Am 2/25/2013 7:54, schrieb Junio C Hamano:
> > Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> > 
> >> As I mentioned recently, while discussing a cygwin specific patch
> >> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
> >> MSVC build is broken for me.
> >>
> >> The first 4 patches fix the MSVC build for me. The final patch is
> >> not really related to fixing the build, but it removed some make
> >> warnings which were quite irritating ...
> >>
> >> Note that I used the Makefile, with the Visual C++ 2008 command
> >> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.
> >> I'm not subscribed to the msysgit mailing list, nor do I follow the
> >> msysgit fork of git, so these patches may conflict with commits in
> >> their repository.
> > 
> > Did anything further happen to this topic in the Windows land?
> 
> I successfully built with MSVC with these patches (but I am not using the
> result anywhere nor did I attempt to run the test suite).
> 
> More importantly, I'm using git on Windows ("MinGW flavor") with these
> patches in production, so there are no obvious regressions.
> 
> Feel free to add my
> 
> Tested-by: Johannes Sixt <j6t@kdbg.org>
> 
> but if you don't have the patches around, I can resend them.
Can you please send a pull request on GitHub?

Thanks, Johannes

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Johannes Sixt· Feb 26, 2013, 19:48 UTC · re: Johannes Schindelin · lore

Re: [msysGit] Re: [PATCH 0/5] Fix msvc build

Am 25.02.2013 20:01, schrieb Johannes Schindelin:
> Can you please send a pull request on GitHub?
It's not github, but hopefully useful for you:
The following changes since commit bcd45b4085f9269a536c8fb1963ac8380bfac0e8:
  Update draft release notes to 1.8.2 (2013-02-01 12:52:08 -0800)
are available in the git repository at:
  git://repo.or.cz/git/mingw/j6t.git rj/msvc
for you to fetch changes up to 4c3f0410bfc3f42f9c62c7a23a0ef78420967f84:
  msvc: avoid collisions between "tags" and "TAGS" (2013-02-26 20:40:16
+0100)
----------------------------------------------------------------
Ramsay Allan Jones (5):
      msvc: Fix compilation errors caused by poll.h emulation
      msvc: git-daemon: Fix linker "unresolved external" errors
      msvc: Fix build by adding missing symbol defines
      msvc: test-svn-fe: Fix linker "unresolved external" error
      msvc: avoid collisions between "tags" and "TAGS"
 compat/msvc.h                     | 2 ++
 compat/vcbuild/include/sys/poll.h | 1 -
 compat/vcbuild/include/unistd.h   | 3 +++
 config.mak.uname                  | 4 +++-
 git-compat-util.h                 | 3 +++
 test-svn-fe.c                     | 2 +-
 6 files changed, 12 insertions(+), 3 deletions(-)
 delete mode 100644 compat/vcbuild/include/sys/poll.h
Ramsay Jones· Feb 26, 2013, 19:06 UTC · re: Johannes Sixt · lore

Re: [PATCH 0/5] Fix msvc build

Johannes Sixt wrote:
Show 28 quoted lines
> Am 2/25/2013 7:54, schrieb Junio C Hamano:
>> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>>
>>> As I mentioned recently, while discussing a cygwin specific patch
>>> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
>>> MSVC build is broken for me.
>>>
>>> The first 4 patches fix the MSVC build for me. The final patch is
>>> not really related to fixing the build, but it removed some make
>>> warnings which were quite irritating ...
>>>
>>> Note that I used the Makefile, with the Visual C++ 2008 command
>>> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.
>>> I'm not subscribed to the msysgit mailing list, nor do I follow the
>>> msysgit fork of git, so these patches may conflict with commits in
>>> their repository.
>>
>> Did anything further happen to this topic in the Windows land?
> 
> I successfully built with MSVC with these patches (but I am not using the
> result anywhere nor did I attempt to run the test suite).
> 
> More importantly, I'm using git on Windows ("MinGW flavor") with these
> patches in production, so there are no obvious regressions.
> 
> Feel free to add my
> 
> Tested-by: Johannes Sixt <j6t@kdbg.org>
Johannes, thank you for taking the time to test these patches.

ATB, Ramsay Jones

← back to recent threads