{"thread":{"id":"32796","subject":"[PATCH 0/5] Fix msvc build","startedAt":"2013-01-31T18:26:46Z","lastAt":"2013-02-26T19:48:09Z","messageCount":8,"participants":["Ramsay Jones","Johannes Schindelin","Junio C Hamano","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"208381","messageId":"510AB766.4030806@ramsay1.demon.co.uk","threadId":"32796","inReplyTo":null,"subject":"[PATCH 0/5] Fix msvc build","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2013-01-31T18:26:46Z","receivedAt":"2013-01-31T18:26:46Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nAs I mentioned recently, while discussing a cygwin specific patch\n(see \"Version 1.8.1 does not compile on Cygwin 1.7.14\" thread), the\nMSVC build is broken for me.\n\nThe first 4 patches fix the MSVC build for me. The final patch is\nnot really related to fixing the build, but it removed some make\nwarnings which were quite irritating ...\n\nNote that I used the Makefile, with the Visual C++ 2008 command\nline compiler on Windows XP (SP3), to build a vanilla git on MinGW.\nI'm not subscribed to the msysgit mailing list, nor do I follow the\nmsysgit fork of git, so these patches may conflict with commits in\ntheir repository.\n\nHTH\n\nATB,\nRamsay Jones\n\nRamsay Jones (5):\n msvc: Fix compilation errors caused by poll.h emulation\n msvc: git-daemon: Fix linker \"unresolved external\" errors\n msvc: Fix build by adding missing symbol defines\n msvc: test-svn-fe: Fix linker \"unresolved external\" error\n msvc: avoid collisions between \"tags\" and \"TAGS\"\n\n compat/msvc.h | 2 ++\n compat/vcbuild/include/sys/poll.h | 1 -\n compat/vcbuild/include/unistd.h | 3 +++\n config.mak.uname | 4 +++-\n git-compat-util.h | 3 +++\n test-svn-fe.c | 2 +-\n 6 files changed, 12 insertions(+), 3 deletions(-)\n delete mode 100644 compat/vcbuild/include/sys/poll.h\n\n-- \n1.8.1\n"},{"id":"208388","messageId":"alpine.DEB.1.00.1301311956470.32206@s15462909.onlinehome-server.info","threadId":"32796","inReplyTo":"510AB766.4030806@ramsay1.demon.co.uk","subject":"Re: [PATCH 0/5] Fix msvc build","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2013-01-31T18:57:21Z","receivedAt":"2013-01-31T18:57:21Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Ramsay,\n\nOn Thu, 31 Jan 2013, Ramsay Jones wrote:\n\n> As I mentioned recently, while discussing a cygwin specific patch\n> (see \"Version 1.8.1 does not compile on Cygwin 1.7.14\" thread), the\n> MSVC build is broken for me.\n> \n> The first 4 patches fix the MSVC build for me. The final patch is\n> not really related to fixing the build, but it removed some make\n> warnings which were quite irritating ...\n\nThanks!\n\n> Note that I used the Makefile, with the Visual C++ 2008 command line\n> compiler on Windows XP (SP3), to build a vanilla git on MinGW. I'm not\n> subscribed to the msysgit mailing list, nor do I follow the msysgit fork\n> of git, so these patches may conflict with commits in their repository.\n\nMaybe you can Cc: the patch series to msysgit@googlegroups.com\nnevertheless?\n\nThanks,\nDscho\n"},{"id":"208392","messageId":"7vmwvpgnj4.fsf@alter.siamese.dyndns.org","threadId":"32796","inReplyTo":"alpine.DEB.1.00.1301311956470.32206@s15462909.onlinehome-server.info","subject":"Re: [PATCH 0/5] Fix msvc build","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-31T19:28:31Z","receivedAt":"2013-01-31T19:28:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi Ramsay,\n>\n> On Thu, 31 Jan 2013, Ramsay Jones wrote:\n>\n>> As I mentioned recently, while discussing a cygwin specific patch\n>> (see \"Version 1.8.1 does not compile on Cygwin 1.7.14\" thread), the\n>> MSVC build is broken for me.\n>> \n>> The first 4 patches fix the MSVC build for me. The final patch is\n>> not really related to fixing the build, but it removed some make\n>> warnings which were quite irritating ...\n>\n> Thanks!\n>\n>> Note that I used the Makefile, with the Visual C++ 2008 command line\n>> compiler on Windows XP (SP3), to build a vanilla git on MinGW. I'm not\n>> subscribed to the msysgit mailing list, nor do I follow the msysgit fork\n>> of git, so these patches may conflict with commits in their repository.\n>\n> Maybe you can Cc: the patch series to msysgit@googlegroups.com\n> nevertheless?\n\nOK. The only thing I can say about these patches is that none of\nthem would affect my boxes would exercise, so I'll wait until I get\na final-for-application re-send from mysgit folks, preferrably with\ntheir Acked-by: lines.\n\nThanks.\n"},{"id":"210232","messageId":"7vehg4288w.fsf@alter.siamese.dyndns.org","threadId":"32796","inReplyTo":"510AB766.4030806@ramsay1.demon.co.uk","subject":"Re: [PATCH 0/5] Fix msvc build","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-02-25T06:54:55Z","receivedAt":"2013-02-25T06:54:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones writes:\n\n> As I mentioned recently, while discussing a cygwin specific patch\n> (see \"Version 1.8.1 does not compile on Cygwin 1.7.14\" thread), the\n> MSVC build is broken for me.\n>\n> The first 4 patches fix the MSVC build for me. The final patch is\n> not really related to fixing the build, but it removed some make\n> warnings which were quite irritating ...\n>\n> Note that I used the Makefile, with the Visual C++ 2008 command\n> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.\n> I'm not subscribed to the msysgit mailing list, nor do I follow the\n> msysgit fork of git, so these patches may conflict with commits in\n> their repository.\n\nDid anything further happen to this topic in the Windows land?\n"},{"id":"210236","messageId":"512B2003.804@viscovery.net","threadId":"32796","inReplyTo":"7vehg4288w.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 0/5] Fix msvc build","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2013-02-25T08:25:39Z","receivedAt":"2013-02-25T08:25:39Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 2/25/2013 7:54, schrieb Junio C Hamano:\n> Ramsay Jones writes:\n> \n>> As I mentioned recently, while discussing a cygwin specific patch\n>> (see \"Version 1.8.1 does not compile on Cygwin 1.7.14\" thread), the\n>> MSVC build is broken for me.\n>>\n>> The first 4 patches fix the MSVC build for me. The final patch is\n>> not really related to fixing the build, but it removed some make\n>> warnings which were quite irritating ...\n>>\n>> Note that I used the Makefile, with the Visual C++ 2008 command\n>> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.\n>> I'm not subscribed to the msysgit mailing list, nor do I follow the\n>> msysgit fork of git, so these patches may conflict with commits in\n>> their repository.\n> \n> Did anything further happen to this topic in the Windows land?\n\nI successfully built with MSVC with these patches (but I am not using the\nresult anywhere nor did I attempt to run the test suite).\n\nMore importantly, I'm using git on Windows (\"MinGW flavor\") with these\npatches in production, so there are no obvious regressions.\n\nFeel free to add my\n\nTested-by: Johannes Sixt \n\nbut if you don't have the patches around, I can resend them.\n\n-- Hannes\n"},{"id":"210272","messageId":"alpine.DEB.1.00.1302252000440.32206@s15462909.onlinehome-server.info","threadId":"32796","inReplyTo":"512B2003.804@viscovery.net","subject":"Re: [PATCH 0/5] Fix msvc build","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2013-02-25T19:01:21Z","receivedAt":"2013-02-25T19:01:21Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Hannes,\n\nOn Mon, 25 Feb 2013, Johannes Sixt wrote:\n\n> Am 2/25/2013 7:54, schrieb Junio C Hamano:\n> > Ramsay Jones writes:\n> > \n> >> As I mentioned recently, while discussing a cygwin specific patch\n> >> (see \"Version 1.8.1 does not compile on Cygwin 1.7.14\" thread), the\n> >> MSVC build is broken for me.\n> >>\n> >> The first 4 patches fix the MSVC build for me. The final patch is\n> >> not really related to fixing the build, but it removed some make\n> >> warnings which were quite irritating ...\n> >>\n> >> Note that I used the Makefile, with the Visual C++ 2008 command\n> >> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.\n> >> I'm not subscribed to the msysgit mailing list, nor do I follow the\n> >> msysgit fork of git, so these patches may conflict with commits in\n> >> their repository.\n> > \n> > Did anything further happen to this topic in the Windows land?\n> \n> I successfully built with MSVC with these patches (but I am not using the\n> result anywhere nor did I attempt to run the test suite).\n> \n> More importantly, I'm using git on Windows (\"MinGW flavor\") with these\n> patches in production, so there are no obvious regressions.\n> \n> Feel free to add my\n> \n> Tested-by: Johannes Sixt \n> \n> but if you don't have the patches around, I can resend them.\n\nCan you please send a pull request on GitHub?\n\nThanks,\nJohannes\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/groups/opt_out.\n"},{"id":"210350","messageId":"512D079B.2070404@ramsay1.demon.co.uk","threadId":"32796","inReplyTo":"512B2003.804@viscovery.net","subject":"Re: [PATCH 0/5] Fix msvc build","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2013-02-26T19:06:03Z","receivedAt":"2013-02-26T19:06:03Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Johannes Sixt wrote:\n> Am 2/25/2013 7:54, schrieb Junio C Hamano:\n>> Ramsay Jones writes:\n>>\n>>> As I mentioned recently, while discussing a cygwin specific patch\n>>> (see \"Version 1.8.1 does not compile on Cygwin 1.7.14\" thread), the\n>>> MSVC build is broken for me.\n>>>\n>>> The first 4 patches fix the MSVC build for me. The final patch is\n>>> not really related to fixing the build, but it removed some make\n>>> warnings which were quite irritating ...\n>>>\n>>> Note that I used the Makefile, with the Visual C++ 2008 command\n>>> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.\n>>> I'm not subscribed to the msysgit mailing list, nor do I follow the\n>>> msysgit fork of git, so these patches may conflict with commits in\n>>> their repository.\n>>\n>> Did anything further happen to this topic in the Windows land?\n> \n> I successfully built with MSVC with these patches (but I am not using the\n> result anywhere nor did I attempt to run the test suite).\n> \n> More importantly, I'm using git on Windows (\"MinGW flavor\") with these\n> patches in production, so there are no obvious regressions.\n> \n> Feel free to add my\n> \n> Tested-by: Johannes Sixt \n\nJohannes, thank you for taking the time to test these patches.\n\nATB,\nRamsay Jones\n"},{"id":"210357","messageId":"512D1179.7030009@kdbg.org","threadId":"32796","inReplyTo":"alpine.DEB.1.00.1302252000440.32206@s15462909.onlinehome-server.info","subject":"Re: [msysGit] Re: [PATCH 0/5] Fix msvc build","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2013-02-26T19:48:09Z","receivedAt":"2013-02-26T19:48:09Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 25.02.2013 20:01, schrieb Johannes Schindelin:\n> Can you please send a pull request on GitHub?\n\nIt's not github, but hopefully useful for you:\n\nThe following changes since commit bcd45b4085f9269a536c8fb1963ac8380bfac0e8:\n\n Update draft release notes to 1.8.2 (2013-02-01 12:52:08 -0800)\n\nare available in the git repository at:\n\n git://repo.or.cz/git/mingw/j6t.git rj/msvc\n\nfor you to fetch changes up to 4c3f0410bfc3f42f9c62c7a23a0ef78420967f84:\n\n msvc: avoid collisions between \"tags\" and \"TAGS\" (2013-02-26 20:40:16\n+0100)\n\n----------------------------------------------------------------\nRamsay Allan Jones (5):\n msvc: Fix compilation errors caused by poll.h emulation\n msvc: git-daemon: Fix linker \"unresolved external\" errors\n msvc: Fix build by adding missing symbol defines\n msvc: test-svn-fe: Fix linker \"unresolved external\" error\n msvc: avoid collisions between \"tags\" and \"TAGS\"\n\n compat/msvc.h | 2 ++\n compat/vcbuild/include/sys/poll.h | 1 -\n compat/vcbuild/include/unistd.h | 3 +++\n config.mak.uname | 4 +++-\n git-compat-util.h | 3 +++\n test-svn-fe.c | 2 +-\n 6 files changed, 12 insertions(+), 3 deletions(-)\n delete mode 100644 compat/vcbuild/include/sys/poll.h\n"}]}