# [PATCH 0/5] Fix msvc build 8 messages from 2013-01-31 to 2013-02-26. Participants: Ramsay Jones, Johannes Schindelin, Junio C Hamano, Johannes Sixt. Thread: https://gitlist.dev/t/32796 ## Ramsay Jones, 2013-01-31 18:26 Subject: [PATCH 0/5] Fix msvc build Message-ID: <510AB766.4030806@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/510AB766.4030806%40ramsay1.demon.co.uk ``` As I mentioned recently, while discussing a cygwin specific patch (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the MSVC build is broken for me. The first 4 patches fix the MSVC build for me. The final patch is not really related to fixing the build, but it removed some make warnings which were quite irritating ... Note that I used the Makefile, with the Visual C++ 2008 command line compiler on Windows XP (SP3), to build a vanilla git on MinGW. I'm not subscribed to the msysgit mailing list, nor do I follow the msysgit fork of git, so these patches may conflict with commits in their repository. HTH ATB, Ramsay Jones Ramsay Jones (5): msvc: Fix compilation errors caused by poll.h emulation msvc: git-daemon: Fix linker "unresolved external" errors msvc: Fix build by adding missing symbol defines msvc: test-svn-fe: Fix linker "unresolved external" error msvc: avoid collisions between "tags" and "TAGS" compat/msvc.h | 2 ++ compat/vcbuild/include/sys/poll.h | 1 - compat/vcbuild/include/unistd.h | 3 +++ config.mak.uname | 4 +++- git-compat-util.h | 3 +++ test-svn-fe.c | 2 +- 6 files changed, 12 insertions(+), 3 deletions(-) delete mode 100644 compat/vcbuild/include/sys/poll.h -- 1.8.1 ``` ## Johannes Schindelin, 2013-01-31 18:57 Subject: Re: [PATCH 0/5] Fix msvc build Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.1301311956470.32206%40s15462909.onlinehome-server.info In-Reply-To: <510AB766.4030806@ramsay1.demon.co.uk> ``` Hi Ramsay, On Thu, 31 Jan 2013, Ramsay Jones wrote: > As I mentioned recently, while discussing a cygwin specific patch > (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the > MSVC build is broken for me. > > The first 4 patches fix the MSVC build for me. The final patch is > not really related to fixing the build, but it removed some make > warnings which were quite irritating ... Thanks! > Note that I used the Makefile, with the Visual C++ 2008 command line > compiler on Windows XP (SP3), to build a vanilla git on MinGW. I'm not > subscribed to the msysgit mailing list, nor do I follow the msysgit fork > of git, so these patches may conflict with commits in their repository. Maybe you can Cc: the patch series to msysgit@googlegroups.com nevertheless? Thanks, Dscho ``` ## Junio C Hamano, 2013-01-31 19:28 Subject: Re: [PATCH 0/5] Fix msvc build Message-ID: <7vmwvpgnj4.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmwvpgnj4.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Johannes Schindelin writes: > Hi Ramsay, > > On Thu, 31 Jan 2013, Ramsay Jones wrote: > >> As I mentioned recently, while discussing a cygwin specific patch >> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the >> MSVC build is broken for me. >> >> The first 4 patches fix the MSVC build for me. The final patch is >> not really related to fixing the build, but it removed some make >> warnings which were quite irritating ... > > Thanks! > >> Note that I used the Makefile, with the Visual C++ 2008 command line >> compiler on Windows XP (SP3), to build a vanilla git on MinGW. I'm not >> subscribed to the msysgit mailing list, nor do I follow the msysgit fork >> of git, so these patches may conflict with commits in their repository. > > Maybe you can Cc: the patch series to msysgit@googlegroups.com > nevertheless? OK. The only thing I can say about these patches is that none of them would affect my boxes would exercise, so I'll wait until I get a final-for-application re-send from mysgit folks, preferrably with their Acked-by: lines. Thanks. ``` ## Junio C Hamano, 2013-02-25 06:54 Subject: Re: [PATCH 0/5] Fix msvc build Message-ID: <7vehg4288w.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vehg4288w.fsf%40alter.siamese.dyndns.org In-Reply-To: <510AB766.4030806@ramsay1.demon.co.uk> ``` Ramsay Jones writes: > As I mentioned recently, while discussing a cygwin specific patch > (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the > MSVC build is broken for me. > > The first 4 patches fix the MSVC build for me. The final patch is > not really related to fixing the build, but it removed some make > warnings which were quite irritating ... > > Note that I used the Makefile, with the Visual C++ 2008 command > line compiler on Windows XP (SP3), to build a vanilla git on MinGW. > I'm not subscribed to the msysgit mailing list, nor do I follow the > msysgit fork of git, so these patches may conflict with commits in > their repository. Did anything further happen to this topic in the Windows land? ``` ## Johannes Sixt, 2013-02-25 08:25 Subject: Re: [PATCH 0/5] Fix msvc build Message-ID: <512B2003.804@viscovery.net> URL: https://gitlist.dev/e/512B2003.804%40viscovery.net In-Reply-To: <7vehg4288w.fsf@alter.siamese.dyndns.org> ``` Am 2/25/2013 7:54, schrieb Junio C Hamano: > Ramsay Jones writes: > >> As I mentioned recently, while discussing a cygwin specific patch >> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the >> MSVC build is broken for me. >> >> The first 4 patches fix the MSVC build for me. The final patch is >> not really related to fixing the build, but it removed some make >> warnings which were quite irritating ... >> >> Note that I used the Makefile, with the Visual C++ 2008 command >> line compiler on Windows XP (SP3), to build a vanilla git on MinGW. >> I'm not subscribed to the msysgit mailing list, nor do I follow the >> msysgit fork of git, so these patches may conflict with commits in >> their repository. > > Did anything further happen to this topic in the Windows land? I successfully built with MSVC with these patches (but I am not using the result anywhere nor did I attempt to run the test suite). More importantly, I'm using git on Windows ("MinGW flavor") with these patches in production, so there are no obvious regressions. Feel free to add my Tested-by: Johannes Sixt but if you don't have the patches around, I can resend them. -- Hannes ``` ## Johannes Schindelin, 2013-02-25 19:01 Subject: Re: [PATCH 0/5] Fix msvc build Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.1302252000440.32206%40s15462909.onlinehome-server.info In-Reply-To: <512B2003.804@viscovery.net> ``` Hi Hannes, On Mon, 25 Feb 2013, Johannes Sixt wrote: > Am 2/25/2013 7:54, schrieb Junio C Hamano: > > Ramsay Jones writes: > > > >> As I mentioned recently, while discussing a cygwin specific patch > >> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the > >> MSVC build is broken for me. > >> > >> The first 4 patches fix the MSVC build for me. The final patch is > >> not really related to fixing the build, but it removed some make > >> warnings which were quite irritating ... > >> > >> Note that I used the Makefile, with the Visual C++ 2008 command > >> line compiler on Windows XP (SP3), to build a vanilla git on MinGW. > >> I'm not subscribed to the msysgit mailing list, nor do I follow the > >> msysgit fork of git, so these patches may conflict with commits in > >> their repository. > > > > Did anything further happen to this topic in the Windows land? > > I successfully built with MSVC with these patches (but I am not using the > result anywhere nor did I attempt to run the test suite). > > More importantly, I'm using git on Windows ("MinGW flavor") with these > patches in production, so there are no obvious regressions. > > Feel free to add my > > Tested-by: Johannes Sixt > > but if you don't have the patches around, I can resend them. Can you please send a pull request on GitHub? Thanks, Johannes -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. ``` ## Ramsay Jones, 2013-02-26 19:06 Subject: Re: [PATCH 0/5] Fix msvc build Message-ID: <512D079B.2070404@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/512D079B.2070404%40ramsay1.demon.co.uk In-Reply-To: <512B2003.804@viscovery.net> ``` Johannes Sixt wrote: > Am 2/25/2013 7:54, schrieb Junio C Hamano: >> Ramsay Jones writes: >> >>> As I mentioned recently, while discussing a cygwin specific patch >>> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the >>> MSVC build is broken for me. >>> >>> The first 4 patches fix the MSVC build for me. The final patch is >>> not really related to fixing the build, but it removed some make >>> warnings which were quite irritating ... >>> >>> Note that I used the Makefile, with the Visual C++ 2008 command >>> line compiler on Windows XP (SP3), to build a vanilla git on MinGW. >>> I'm not subscribed to the msysgit mailing list, nor do I follow the >>> msysgit fork of git, so these patches may conflict with commits in >>> their repository. >> >> Did anything further happen to this topic in the Windows land? > > I successfully built with MSVC with these patches (but I am not using the > result anywhere nor did I attempt to run the test suite). > > More importantly, I'm using git on Windows ("MinGW flavor") with these > patches in production, so there are no obvious regressions. > > Feel free to add my > > Tested-by: Johannes Sixt Johannes, thank you for taking the time to test these patches. ATB, Ramsay Jones ``` ## Johannes Sixt, 2013-02-26 19:48 Subject: Re: [msysGit] Re: [PATCH 0/5] Fix msvc build Message-ID: <512D1179.7030009@kdbg.org> URL: https://gitlist.dev/e/512D1179.7030009%40kdbg.org In-Reply-To: ``` Am 25.02.2013 20:01, schrieb Johannes Schindelin: > Can you please send a pull request on GitHub? It's not github, but hopefully useful for you: The following changes since commit bcd45b4085f9269a536c8fb1963ac8380bfac0e8: Update draft release notes to 1.8.2 (2013-02-01 12:52:08 -0800) are available in the git repository at: git://repo.or.cz/git/mingw/j6t.git rj/msvc for you to fetch changes up to 4c3f0410bfc3f42f9c62c7a23a0ef78420967f84: msvc: avoid collisions between "tags" and "TAGS" (2013-02-26 20:40:16 +0100) ---------------------------------------------------------------- Ramsay Allan Jones (5): msvc: Fix compilation errors caused by poll.h emulation msvc: git-daemon: Fix linker "unresolved external" errors msvc: Fix build by adding missing symbol defines msvc: test-svn-fe: Fix linker "unresolved external" error msvc: avoid collisions between "tags" and "TAGS" compat/msvc.h | 2 ++ compat/vcbuild/include/sys/poll.h | 1 - compat/vcbuild/include/unistd.h | 3 +++ config.mak.uname | 4 +++- git-compat-util.h | 3 +++ test-svn-fe.c | 2 +- 6 files changed, 12 insertions(+), 3 deletions(-) delete mode 100644 compat/vcbuild/include/sys/poll.h ```