git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Fix msvc build

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Feb 26, 2013, 19:06 UTC
Message-ID
<512D079B.2070404@ramsay1.demon.co.uk>
In-Reply-To
<512B2003.804@viscovery.net>
Johannes Sixt wrote:
Show 28 quoted lines
> Am 2/25/2013 7:54, schrieb Junio C Hamano:
>> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>>
>>> As I mentioned recently, while discussing a cygwin specific patch
>>> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
>>> MSVC build is broken for me.
>>>
>>> The first 4 patches fix the MSVC build for me. The final patch is
>>> not really related to fixing the build, but it removed some make
>>> warnings which were quite irritating ...
>>>
>>> Note that I used the Makefile, with the Visual C++ 2008 command
>>> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.
>>> I'm not subscribed to the msysgit mailing list, nor do I follow the
>>> msysgit fork of git, so these patches may conflict with commits in
>>> their repository.
>>
>> Did anything further happen to this topic in the Windows land?
> 
> I successfully built with MSVC with these patches (but I am not using the
> result anywhere nor did I attempt to run the test suite).
> 
> More importantly, I'm using git on Windows ("MinGW flavor") with these
> patches in production, so there are no obvious regressions.
> 
> Feel free to add my
> 
> Tested-by: Johannes Sixt <j6t@kdbg.org>
Johannes, thank you for taking the time to test these patches.

ATB, Ramsay Jones

Previous: Johannes Sixt
Message 8 of 8 in “Fix msvc build”
  1. 0/5 Fix msvc buildRamsay Jones, Jan 31, 2013
  2. Johannes SchindelinJan 31, 2013
  3. Junio C HamanoJan 31, 2013
  4. Junio C HamanoFeb 25, 2013
  5. Johannes SixtFeb 25, 2013
  6. Johannes SchindelinFeb 25, 2013
  7. Johannes SixtFeb 26, 2013
  8. Ramsay JonesFeb 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.