threads / patch / 32782

patchgit_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"

Subject: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"

## tl;dr

2 messages between Jan 30, 2013 and Jan 30, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Junio C Hamano· Jan 30, 2013, 19:30 UTC · lore

fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20) started using a marker file to keep track of the version of Python interpreter used for the last build, but forgot to remove it when asked to "make clean".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git_remote_helpers/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to git_remote_helpers/Makefile +1 −1

diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
index 0d2ae74..3d12232 100644
--- a/git_remote_helpers/Makefile
+++ b/git_remote_helpers/Makefile
@@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
 
 clean:
 	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
-	$(RM) *.pyo *.pyc
+	$(RM) *.pyo *.pyc GIT-PYTHON-VERSION

John Keeping· Jan 30, 2013, 20:03 UTC · re: Junio C Hamano · lore

Re: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"

On Wed, Jan 30, 2013 at 11:30:10AM -0800, Junio C Hamano wrote:

Show 5 quoted lines

> fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)
> started using a marker file to keep track of the version of Python interpreter
> used for the last build, but forgot to remove it when asked to "make clean".
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Looks obviously correct to me. Sorry for missing this at the time. FWIW:

Reviewed-by: John Keeping <john@keeping.me.uk>

Show 14 quoted lines

> ---
>  git_remote_helpers/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
> index 0d2ae74..3d12232 100644
> --- a/git_remote_helpers/Makefile
> +++ b/git_remote_helpers/Makefile
> @@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
>  
>  clean:
>  	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
> -	$(RM) *.pyo *.pyc
> +	$(RM) *.pyo *.pyc GIT-PYTHON-VERSION