# [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"

2 messages from 2013-01-30 to 2013-01-30. Participants: Junio C Hamano, John Keeping.
Thread: https://gitlist.dev/t/32782

## Junio C Hamano, 2013-01-30 19:30

Subject: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"
Message-ID: <7vzjzqjwot.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vzjzqjwot.fsf%40alter.siamese.dyndns.org

```
fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)
started using a marker file to keep track of the version of Python interpreter
used for the last build, but forgot to remove it when asked to "make clean".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git_remote_helpers/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
index 0d2ae74..3d12232 100644
--- a/git_remote_helpers/Makefile
+++ b/git_remote_helpers/Makefile
@@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
 
 clean:
 	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
-	$(RM) *.pyo *.pyc
+	$(RM) *.pyo *.pyc GIT-PYTHON-VERSION

```

## John Keeping, 2013-01-30 20:03

Subject: Re: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"
Message-ID: <20130130200356.GL1342@serenity.lan>
URL: https://gitlist.dev/e/20130130200356.GL1342%40serenity.lan
In-Reply-To: <7vzjzqjwot.fsf@alter.siamese.dyndns.org>

```
On Wed, Jan 30, 2013 at 11:30:10AM -0800, Junio C Hamano wrote:
> fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)
> started using a marker file to keep track of the version of Python interpreter
> used for the last build, but forgot to remove it when asked to "make clean".
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Looks obviously correct to me.  Sorry for missing this at the time.
FWIW:

Reviewed-by: John Keeping <john@keeping.me.uk>

> ---
>  git_remote_helpers/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
> index 0d2ae74..3d12232 100644
> --- a/git_remote_helpers/Makefile
> +++ b/git_remote_helpers/Makefile
> @@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
>  
>  clean:
>  	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
> -	$(RM) *.pyo *.pyc
> +	$(RM) *.pyo *.pyc GIT-PYTHON-VERSION

```
