Re: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"

From: John Keeping <john@keeping.me.uk>
Date: Jan 30, 2013, 20:03 UTC
Message-ID: <20130130200356.GL1342@serenity.lan>
In-Reply-To: <7vzjzqjwot.fsf@alter.siamese.dyndns.org>

On Wed, Jan 30, 2013 at 11:30:10AM -0800, Junio C Hamano wrote:

Show 5 quoted lines

> fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)
> started using a marker file to keep track of the version of Python interpreter
> used for the last build, but forgot to remove it when asked to "make clean".
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Looks obviously correct to me. Sorry for missing this at the time. FWIW:

Reviewed-by: John Keeping <john@keeping.me.uk>

Show 14 quoted lines

> ---
>  git_remote_helpers/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
> index 0d2ae74..3d12232 100644
> --- a/git_remote_helpers/Makefile
> +++ b/git_remote_helpers/Makefile
> @@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
>  
>  clean:
>  	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
> -	$(RM) *.pyo *.pyc
> +	$(RM) *.pyo *.pyc GIT-PYTHON-VERSION