{"thread":{"id":"32782","subject":"[PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon \"clean\"","startedAt":"2013-01-30T19:30:10Z","lastAt":"2013-01-30T20:03:56Z","messageCount":2,"participants":["Junio C Hamano","John Keeping"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"208304","messageId":"7vzjzqjwot.fsf@alter.siamese.dyndns.org","threadId":"32782","inReplyTo":null,"subject":"[PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon \"clean\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-30T19:30:10Z","receivedAt":"2013-01-30T19:30:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)\nstarted using a marker file to keep track of the version of Python interpreter\nused for the last build, but forgot to remove it when asked to \"make clean\".\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n git_remote_helpers/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile\nindex 0d2ae74..3d12232 100644\n--- a/git_remote_helpers/Makefile\n+++ b/git_remote_helpers/Makefile\n@@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)\n \n clean:\n \t$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a\n-\t$(RM) *.pyo *.pyc\n+\t$(RM) *.pyo *.pyc GIT-PYTHON-VERSION\n"},{"id":"208311","messageId":"20130130200356.GL1342@serenity.lan","threadId":"32782","inReplyTo":"7vzjzqjwot.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon \"clean\"","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-01-30T20:03:56Z","receivedAt":"2013-01-30T20:03:56Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"On Wed, Jan 30, 2013 at 11:30:10AM -0800, Junio C Hamano wrote:\n> fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)\n> started using a marker file to keep track of the version of Python interpreter\n> used for the last build, but forgot to remove it when asked to \"make clean\".\n> \n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n\nLooks obviously correct to me.  Sorry for missing this at the time.\nFWIW:\n\nReviewed-by: John Keeping <john@keeping.me.uk>\n\n> ---\n>  git_remote_helpers/Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile\n> index 0d2ae74..3d12232 100644\n> --- a/git_remote_helpers/Makefile\n> +++ b/git_remote_helpers/Makefile\n> @@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)\n>  \n>  clean:\n>  \t$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a\n> -\t$(RM) *.pyo *.pyc\n> +\t$(RM) *.pyo *.pyc GIT-PYTHON-VERSION\n"}]}