threads / patch / 32502

patch, 4 partst4014: do not uese echo -n

Subject: [PATCH 3/4] t4014: do not uese echo -n

## tl;dr

3 messages between Jan 1, 2013 and Jan 2, 2013. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Torsten Bögershausen· Jan 1, 2013, 21:41 UTC · lore

echo -n is not portable on all systems. Use printf instead

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 t/t4014-format-patch.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t4014-format-patch.sh +1 −1

diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 6cfad13..f460930 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -993,7 +993,7 @@ EOF
 '
 
 test_expect_success 'signoff: commit with only subject that does not end with NL' '
-	echo -n subject | append_signoff >actual &&
+	printf subject | append_signoff >actual &&
 	cat >expected <<\EOF &&
 4:Subject: [PATCH] subject
 8:

-- 
1.8.0.197.g5a90748

Junio C Hamano· Jan 2, 2013, 01:16 UTC · re: Torsten Bögershausen · lore

Re: [PATCH 3/4] t4014: do not uese echo -n

Torsten Bögershausen <tboegi@web.de> writes:

Show 5 quoted lines

> echo -n is not portable on all systems.
> Use printf instead
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---

Brandon, this comes from 932581b (Unify appending signoff in format-patch, commit and sequencer, 2012-11-25). Please make sure to squash it in when you reroll the series.

Thanks (and a happy new year ;-).

Show 16 quoted lines

>  t/t4014-format-patch.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 6cfad13..f460930 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -993,7 +993,7 @@ EOF
>  '
>  
>  test_expect_success 'signoff: commit with only subject that does not end with NL' '
> -	echo -n subject | append_signoff >actual &&
> +	printf subject | append_signoff >actual &&
>  	cat >expected <<\EOF &&
>  4:Subject: [PATCH] subject
>  8:

Brandon Casey· Jan 2, 2013, 08:42 UTC · re: Junio C Hamano · lore

Re: [PATCH 3/4] t4014: do not uese echo -n

On Tue, Jan 1, 2013 at 5:16 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
>
>> echo -n is not portable on all systems.
>> Use printf instead
>>
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>> ---
>
> Brandon, this comes from 932581b (Unify appending signoff in
> format-patch, commit and sequencer, 2012-11-25).  Please make sure
> to squash it in when you reroll the series.

Will do.

> Thanks (and a happy new year ;-).

Thanks.  Happy New Year to you too. :)

-Brandon