# [PATCH 3/4] t4014: do not uese echo -n 3 messages from 2013-01-01 to 2013-01-02. Participants: Torsten Bögershausen, Junio C Hamano, Brandon Casey. Thread: https://gitlist.dev/t/32502 ## Torsten Bögershausen, 2013-01-01 21:41 Subject: [PATCH 3/4] t4014: do not uese echo -n Message-ID: <201301012241.17050.tboegi@web.de> URL: https://gitlist.dev/e/201301012241.17050.tboegi%40web.de ``` echo -n is not portable on all systems. Use printf instead Signed-off-by: Torsten Bögershausen --- t/t4014-format-patch.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 6cfad13..f460930 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -993,7 +993,7 @@ EOF ' test_expect_success 'signoff: commit with only subject that does not end with NL' ' - echo -n subject | append_signoff >actual && + printf subject | append_signoff >actual && cat >expected <<\EOF && 4:Subject: [PATCH] subject 8: -- 1.8.0.197.g5a90748 ``` ## Junio C Hamano, 2013-01-02 01:16 Subject: Re: [PATCH 3/4] t4014: do not uese echo -n Message-ID: <7vwqvw5qpg.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vwqvw5qpg.fsf%40alter.siamese.dyndns.org In-Reply-To: <201301012241.17050.tboegi@web.de> ``` Torsten Bögershausen writes: > echo -n is not portable on all systems. > Use printf instead > > Signed-off-by: Torsten Bögershausen > --- Brandon, this comes from 932581b (Unify appending signoff in format-patch, commit and sequencer, 2012-11-25). Please make sure to squash it in when you reroll the series. Thanks (and a happy new year ;-). > t/t4014-format-patch.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh > index 6cfad13..f460930 100755 > --- a/t/t4014-format-patch.sh > +++ b/t/t4014-format-patch.sh > @@ -993,7 +993,7 @@ EOF > ' > > test_expect_success 'signoff: commit with only subject that does not end with NL' ' > - echo -n subject | append_signoff >actual && > + printf subject | append_signoff >actual && > cat >expected <<\EOF && > 4:Subject: [PATCH] subject > 8: ``` ## Brandon Casey, 2013-01-02 08:42 Subject: Re: [PATCH 3/4] t4014: do not uese echo -n Message-ID: URL: https://gitlist.dev/e/CA%2BsFfMc%3DZJ0%3DLyYBmEWTJFY_eDi4qLZv9Fz%2B1m6SkRO9WF8zOQ%40mail.gmail.com In-Reply-To: <7vwqvw5qpg.fsf@alter.siamese.dyndns.org> ``` On Tue, Jan 1, 2013 at 5:16 PM, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> echo -n is not portable on all systems. >> Use printf instead >> >> Signed-off-by: Torsten Bögershausen >> --- > > Brandon, this comes from 932581b (Unify appending signoff in > format-patch, commit and sequencer, 2012-11-25). Please make sure > to squash it in when you reroll the series. Will do. > Thanks (and a happy new year ;-). Thanks. Happy New Year to you too. :) -Brandon ```