Re: [PATCH 3/4] t4014: do not uese echo -n

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 2, 2013, 01:16 UTC
Message-ID: <7vwqvw5qpg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201301012241.17050.tboegi@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 5 quoted lines

> echo -n is not portable on all systems.
> Use printf instead
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---

Brandon, this comes from 932581b (Unify appending signoff in format-patch, commit and sequencer, 2012-11-25). Please make sure to squash it in when you reroll the series.

Thanks (and a happy new year ;-).

Show 16 quoted lines

>  t/t4014-format-patch.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 6cfad13..f460930 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -993,7 +993,7 @@ EOF
>  '
>  
>  test_expect_success 'signoff: commit with only subject that does not end with NL' '
> -	echo -n subject | append_signoff >actual &&
> +	printf subject | append_signoff >actual &&
>  	cat >expected <<\EOF &&
>  4:Subject: [PATCH] subject
>  8: