{"thread":{"id":"32502","subject":"[PATCH 3/4] t4014: do not uese echo -n","startedAt":"2013-01-01T21:41:15Z","lastAt":"2013-01-02T08:42:32Z","messageCount":3,"participants":["Torsten Bögershausen","Junio C Hamano","Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"205790","messageId":"201301012241.17050.tboegi@web.de","threadId":"32502","inReplyTo":null,"subject":"[PATCH 3/4] t4014: do not uese echo -n","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-01-01T21:41:15Z","receivedAt":"2013-01-01T21:41:15Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"echo -n is not portable on all systems.\nUse printf instead\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t4014-format-patch.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\nindex 6cfad13..f460930 100755\n--- a/t/t4014-format-patch.sh\n+++ b/t/t4014-format-patch.sh\n@@ -993,7 +993,7 @@ EOF\n '\n \n test_expect_success 'signoff: commit with only subject that does not end with NL' '\n-\techo -n subject | append_signoff >actual &&\n+\tprintf subject | append_signoff >actual &&\n \tcat >expected <<\\EOF &&\n 4:Subject: [PATCH] subject\n 8:\n-- \n1.8.0.197.g5a90748\n"},{"id":"205822","messageId":"7vwqvw5qpg.fsf@alter.siamese.dyndns.org","threadId":"32502","inReplyTo":"201301012241.17050.tboegi@web.de","subject":"Re: [PATCH 3/4] t4014: do not uese echo -n","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-01-02T01:16:59Z","receivedAt":"2013-01-02T01:16:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Torsten Bögershausen <tboegi@web.de> writes:\n\n> echo -n is not portable on all systems.\n> Use printf instead\n>\n> Signed-off-by: Torsten Bögershausen <tboegi@web.de>\n> ---\n\nBrandon, this comes from 932581b (Unify appending signoff in\nformat-patch, commit and sequencer, 2012-11-25).  Please make sure\nto squash it in when you reroll the series.\n\nThanks (and a happy new year ;-).\n\n>  t/t4014-format-patch.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\n> index 6cfad13..f460930 100755\n> --- a/t/t4014-format-patch.sh\n> +++ b/t/t4014-format-patch.sh\n> @@ -993,7 +993,7 @@ EOF\n>  '\n>  \n>  test_expect_success 'signoff: commit with only subject that does not end with NL' '\n> -\techo -n subject | append_signoff >actual &&\n> +\tprintf subject | append_signoff >actual &&\n>  \tcat >expected <<\\EOF &&\n>  4:Subject: [PATCH] subject\n>  8:\n"},{"id":"205848","messageId":"CA+sFfMc=ZJ0=LyYBmEWTJFY_eDi4qLZv9Fz+1m6SkRO9WF8zOQ@mail.gmail.com","threadId":"32502","inReplyTo":"7vwqvw5qpg.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 3/4] t4014: do not uese echo -n","fromName":"Brandon Casey","fromEmail":"drafnel@gmail.com","sentAt":"2013-01-02T08:42:32Z","receivedAt":"2013-01-02T08:42:32Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"On Tue, Jan 1, 2013 at 5:16 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Torsten Bögershausen <tboegi@web.de> writes:\n>\n>> echo -n is not portable on all systems.\n>> Use printf instead\n>>\n>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>\n>> ---\n>\n> Brandon, this comes from 932581b (Unify appending signoff in\n> format-patch, commit and sequencer, 2012-11-25).  Please make sure\n> to squash it in when you reroll the series.\n\nWill do.\n\n> Thanks (and a happy new year ;-).\n\nThanks.  Happy New Year to you too. :)\n\n-Brandon\n"}]}