threads / patch / 3054

patchshow-branch: make --topo-order noop and default.

Subject: [PATCH] show-branch: make --topo-order noop and default.

## tl;dr

4 messages between Jan 12, 2006 and Jan 13, 2006. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Junio C Hamano· Jan 12, 2006, 00:05 UTC · lore

It really does not make sense not doing --topo-order.

Signed-off-by: Junio C Hamano <junkio@cox.net>

---
 * Currently in "pu".

 show-branch.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

d899f2bfc64b44e776a87f9c8fdd6abfe819690b

Show changes to show-branch.c +3 −4

diff --git a/show-branch.c b/show-branch.c
index 9f7e188..f296a87 100644
--- a/show-branch.c
+++ b/show-branch.c
@@ -544,7 +544,6 @@ int main(int ac, char **av)
 	int no_name = 0;
 	int sha1_name = 0;
 	int shown_merge_point = 0;
-	int topo_order = 0;
 	int no_current_branch = 0;
 
 	git_config(git_show_branch_config);
@@ -585,7 +584,8 @@ int main(int ac, char **av)
 		else if (!strcmp(arg, "--independent"))
 			independent = 1;
 		else if (!strcmp(arg, "--topo-order"))
-			topo_order = 1;
+			/* noop */
+			;
 		else
 			usage(show_branch_usage);
 		ac--; av++;
@@ -707,8 +707,7 @@ int main(int ac, char **av)
 		exit(0);
 
 	/* Sort topologically */
-	if (topo_order)
-		sort_in_topological_order(&seen);
+	sort_in_topological_order(&seen);
 
 	/* Give names to commits */
 	if (!sha1_name && !no_name)

-- 
1.1.1-g8ecb

A Large Angry SCM· Jan 13, 2006, 02:24 UTC · re: Junio C Hamano · lore

Re: [PATCH] show-branch: make --topo-order noop and default.

Junio C Hamano wrote:

> It really does not make sense not doing --topo-order.
>

I disagree. I do like to see the chronological commit history of some repositories.

Junio C Hamano· Jan 13, 2006, 04:11 UTC · re: A Large Angry SCM · lore

Re: [PATCH] show-branch: make --topo-order noop and default.

A Large Angry SCM <gitzilla@gmail.com> writes:

Show 5 quoted lines

> Junio C Hamano wrote:
>> It really does not make sense not doing --topo-order.
>
> I disagree. I do like to see the chronological commit history of some
> repositories.

But the thing is if you do chronological order, you may not see enough commits without --more=, because show-branches stops at the first common commit. Try it yourself in a repository with merges on topic branches of different vintage, with and without the option, to see where output stops.

A Large Angry SCM· Jan 13, 2006, 05:28 UTC · re: Junio C Hamano · lore

Re: [PATCH] show-branch: make --topo-order noop and default.

Junio C Hamano wrote:

Show 12 quoted lines

> A Large Angry SCM <gitzilla@gmail.com> writes:
> 
>>Junio C Hamano wrote:
>>>It really does not make sense not doing --topo-order.
>>I disagree. I do like to see the chronological commit history of some
>>repositories.
> 
> But the thing is if you do chronological order, you may not see
> enough commits without --more=, because show-branches stops at
> the first common commit.  Try it yourself in a repository with
> merges on topic branches of different vintage, with and without
> the option, to see where output stops.

Interesting, I don't think I've ever looked far enough to triggered the stop condition in my repositories of interest before.

How about making topo-order the default but having an option for chronological order?