{"thread":{"id":"3054","subject":"[PATCH] show-branch: make --topo-order noop and default.","startedAt":"2006-01-12T00:05:54Z","lastAt":"2006-01-13T05:28:21Z","messageCount":4,"participants":["Junio C Hamano","A Large Angry SCM"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"14521","messageId":"7v4q4ajonx.fsf@assigned-by-dhcp.cox.net","threadId":"3054","inReplyTo":null,"subject":"[PATCH] show-branch: make --topo-order noop and default.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-01-12T00:05:54Z","receivedAt":"2006-01-12T00:05:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"It really does not make sense not doing --topo-order.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n\n---\n * Currently in \"pu\".\n\n show-branch.c |    7 +++----\n 1 files changed, 3 insertions(+), 4 deletions(-)\n\nd899f2bfc64b44e776a87f9c8fdd6abfe819690b\ndiff --git a/show-branch.c b/show-branch.c\nindex 9f7e188..f296a87 100644\n--- a/show-branch.c\n+++ b/show-branch.c\n@@ -544,7 +544,6 @@ int main(int ac, char **av)\n \tint no_name = 0;\n \tint sha1_name = 0;\n \tint shown_merge_point = 0;\n-\tint topo_order = 0;\n \tint no_current_branch = 0;\n \n \tgit_config(git_show_branch_config);\n@@ -585,7 +584,8 @@ int main(int ac, char **av)\n \t\telse if (!strcmp(arg, \"--independent\"))\n \t\t\tindependent = 1;\n \t\telse if (!strcmp(arg, \"--topo-order\"))\n-\t\t\ttopo_order = 1;\n+\t\t\t/* noop */\n+\t\t\t;\n \t\telse\n \t\t\tusage(show_branch_usage);\n \t\tac--; av++;\n@@ -707,8 +707,7 @@ int main(int ac, char **av)\n \t\texit(0);\n \n \t/* Sort topologically */\n-\tif (topo_order)\n-\t\tsort_in_topological_order(&seen);\n+\tsort_in_topological_order(&seen);\n \n \t/* Give names to commits */\n \tif (!sha1_name && !no_name)\n-- \n1.1.1-g8ecb\n"},{"id":"14587","messageId":"43C70F69.7010103@gmail.com","threadId":"3054","inReplyTo":"7v4q4ajonx.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] show-branch: make --topo-order noop and default.","fromName":"A Large Angry SCM","fromEmail":"gitzilla@gmail.com","sentAt":"2006-01-13T02:24:41Z","receivedAt":"2006-01-13T02:24:41Z","isPatch":true,"sender":{"key":"gitzilla@gmail.com","avatar":"https://gravatar.com/avatar/354625c442439908ff3dd99757dee330e29e9df7847472384faf7a00add247fb?d=mp&s=160"},"body":"Junio C Hamano wrote:\n> It really does not make sense not doing --topo-order.\n> \n\nI disagree. I do like to see the chronological commit history of some \nrepositories.\n"},{"id":"14599","messageId":"7vslrsg41g.fsf@assigned-by-dhcp.cox.net","threadId":"3054","inReplyTo":"43C70F69.7010103@gmail.com","subject":"Re: [PATCH] show-branch: make --topo-order noop and default.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-01-13T04:11:55Z","receivedAt":"2006-01-13T04:11:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"A Large Angry SCM <gitzilla@gmail.com> writes:\n\n> Junio C Hamano wrote:\n>> It really does not make sense not doing --topo-order.\n>\n> I disagree. I do like to see the chronological commit history of some\n> repositories.\n\nBut the thing is if you do chronological order, you may not see\nenough commits without --more=, because show-branches stops at\nthe first common commit.  Try it yourself in a repository with\nmerges on topic branches of different vintage, with and without\nthe option, to see where output stops.\n"},{"id":"14603","messageId":"43C73A75.6020007@gmail.com","threadId":"3054","inReplyTo":"7vslrsg41g.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] show-branch: make --topo-order noop and default.","fromName":"A Large Angry SCM","fromEmail":"gitzilla@gmail.com","sentAt":"2006-01-13T05:28:21Z","receivedAt":"2006-01-13T05:28:21Z","isPatch":true,"sender":{"key":"gitzilla@gmail.com","avatar":"https://gravatar.com/avatar/354625c442439908ff3dd99757dee330e29e9df7847472384faf7a00add247fb?d=mp&s=160"},"body":"Junio C Hamano wrote:\n> A Large Angry SCM <gitzilla@gmail.com> writes:\n> \n>>Junio C Hamano wrote:\n>>>It really does not make sense not doing --topo-order.\n>>I disagree. I do like to see the chronological commit history of some\n>>repositories.\n> \n> But the thing is if you do chronological order, you may not see\n> enough commits without --more=, because show-branches stops at\n> the first common commit.  Try it yourself in a repository with\n> merges on topic branches of different vintage, with and without\n> the option, to see where output stops.\n\nInteresting, I don't think I've ever looked far enough to triggered the \nstop condition in my repositories of interest before.\n\nHow about making topo-order the default but having an option for \nchronological order?\n"}]}