git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] show-branch: make --topo-order noop and default.

From
Junio C Hamano <junkio@cox.net>
Date
Jan 12, 2006, 00:05 UTC
Message-ID
<7v4q4ajonx.fsf@assigned-by-dhcp.cox.net>
It really does not make sense not doing --topo-order.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 * Currently in "pu".
 show-branch.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
d899f2bfc64b44e776a87f9c8fdd6abfe819690b
diff --git a/show-branch.c b/show-branch.c
index 9f7e188..f296a87 100644
--- a/show-branch.c
+++ b/show-branch.c
@@ -544,7 +544,6 @@ int main(int ac, char **av)
 	int no_name = 0;
 	int sha1_name = 0;
 	int shown_merge_point = 0;
-	int topo_order = 0;
 	int no_current_branch = 0;
 
 	git_config(git_show_branch_config);
@@ -585,7 +584,8 @@ int main(int ac, char **av)
 		else if (!strcmp(arg, "--independent"))
 			independent = 1;
 		else if (!strcmp(arg, "--topo-order"))
-			topo_order = 1;
+			/* noop */
+			;
 		else
 			usage(show_branch_usage);
 		ac--; av++;
@@ -707,8 +707,7 @@ int main(int ac, char **av)
 		exit(0);
 
 	/* Sort topologically */
-	if (topo_order)
-		sort_in_topological_order(&seen);
+	sort_in_topological_order(&seen);
 
 	/* Give names to commits */
 	if (!sha1_name && !no_name)
-- 
1.1.1-g8ecb
Next: A Large Angry SCM
Message 1 of 4 in “show-branch: make --topo-order noop and default.”
  1. show-branch: make --topo-order noop and default.Junio C Hamano, Jan 12, 2006
  2. A Large Angry SCMJan 13, 2006
  3. Junio C HamanoJan 13, 2006
  4. A Large Angry SCMJan 13, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.