# [PATCH] show-branch: make --topo-order noop and default. 4 messages from 2006-01-12 to 2006-01-13. Participants: Junio C Hamano, A Large Angry SCM. Thread: https://gitlist.dev/t/3054 ## Junio C Hamano, 2006-01-12 00:05 Subject: [PATCH] show-branch: make --topo-order noop and default. Message-ID: <7v4q4ajonx.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v4q4ajonx.fsf%40assigned-by-dhcp.cox.net ``` It really does not make sense not doing --topo-order. Signed-off-by: Junio C Hamano --- * Currently in "pu". show-branch.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) d899f2bfc64b44e776a87f9c8fdd6abfe819690b diff --git a/show-branch.c b/show-branch.c index 9f7e188..f296a87 100644 --- a/show-branch.c +++ b/show-branch.c @@ -544,7 +544,6 @@ int main(int ac, char **av) int no_name = 0; int sha1_name = 0; int shown_merge_point = 0; - int topo_order = 0; int no_current_branch = 0; git_config(git_show_branch_config); @@ -585,7 +584,8 @@ int main(int ac, char **av) else if (!strcmp(arg, "--independent")) independent = 1; else if (!strcmp(arg, "--topo-order")) - topo_order = 1; + /* noop */ + ; else usage(show_branch_usage); ac--; av++; @@ -707,8 +707,7 @@ int main(int ac, char **av) exit(0); /* Sort topologically */ - if (topo_order) - sort_in_topological_order(&seen); + sort_in_topological_order(&seen); /* Give names to commits */ if (!sha1_name && !no_name) -- 1.1.1-g8ecb ``` ## A Large Angry SCM, 2006-01-13 02:24 Subject: Re: [PATCH] show-branch: make --topo-order noop and default. Message-ID: <43C70F69.7010103@gmail.com> URL: https://gitlist.dev/e/43C70F69.7010103%40gmail.com In-Reply-To: <7v4q4ajonx.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano wrote: > It really does not make sense not doing --topo-order. > I disagree. I do like to see the chronological commit history of some repositories. ``` ## Junio C Hamano, 2006-01-13 04:11 Subject: Re: [PATCH] show-branch: make --topo-order noop and default. Message-ID: <7vslrsg41g.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vslrsg41g.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <43C70F69.7010103@gmail.com> ``` A Large Angry SCM writes: > Junio C Hamano wrote: >> It really does not make sense not doing --topo-order. > > I disagree. I do like to see the chronological commit history of some > repositories. But the thing is if you do chronological order, you may not see enough commits without --more=, because show-branches stops at the first common commit. Try it yourself in a repository with merges on topic branches of different vintage, with and without the option, to see where output stops. ``` ## A Large Angry SCM, 2006-01-13 05:28 Subject: Re: [PATCH] show-branch: make --topo-order noop and default. Message-ID: <43C73A75.6020007@gmail.com> URL: https://gitlist.dev/e/43C73A75.6020007%40gmail.com In-Reply-To: <7vslrsg41g.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano wrote: > A Large Angry SCM writes: > >>Junio C Hamano wrote: >>>It really does not make sense not doing --topo-order. >>I disagree. I do like to see the chronological commit history of some >>repositories. > > But the thing is if you do chronological order, you may not see > enough commits without --more=, because show-branches stops at > the first common commit. Try it yourself in a repository with > merges on topic branches of different vintage, with and without > the option, to see where output stops. Interesting, I don't think I've ever looked far enough to triggered the stop condition in my repositories of interest before. How about making topo-order the default but having an option for chronological order? ```