threads / patch / 28975

patchgit-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.

Subject: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.

## tl;dr

3 messages between Nov 18, 2011 and Dec 7, 2011. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Samuel Bronson· Nov 18, 2011, 18:13 UTC · lore
It would be better if the 32x32 icon was equivalent to the one used on
Windows (in git-gui.ico), but I'm not sure how that would best be done,
so I copied this code from gitk instead.
---
 git-gui.sh |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
Show changes to git-gui.sh +6 −1
diff --git a/git-gui.sh b/git-gui.sh
index c190cbe..9d01039 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -729,7 +729,12 @@ if {[is_Windows]} {
 		gitlogo put gray26  -to  5 15 11 16
 		gitlogo redither
 
-		wm iconphoto . -default gitlogo
+		# TODO: should use something equivalent to the 32x32 image in
+		# the .ico file
+		image create photo gitlogo32    -width 32 -height 32
+		gitlogo32 copy gitlogo -zoom 2 2
+
+		wm iconphoto . -default gitlogo gitlogo32
 	}
 }
 
-- 
1.7.6.3
Samuel Bronson· Nov 30, 2011, 00:02 UTC · re: Samuel Bronson · lore

Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.

On Fri, Nov 18, 2011 at 1:13 PM, Samuel Bronson <naesten@gmail.com> wrote:
Show 24 quoted lines
> It would be better if the 32x32 icon was equivalent to the one used on
> Windows (in git-gui.ico), but I'm not sure how that would best be done,
> so I copied this code from gitk instead.
> ---
>  git-gui.sh |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index c190cbe..9d01039 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -729,7 +729,12 @@ if {[is_Windows]} {
>                gitlogo put gray26  -to  5 15 11 16
>                gitlogo redither
>
> -               wm iconphoto . -default gitlogo
> +               # TODO: should use something equivalent to the 32x32 image in
> +               # the .ico file
> +               image create photo gitlogo32    -width 32 -height 32
> +               gitlogo32 copy gitlogo -zoom 2 2
> +
> +               wm iconphoto . -default gitlogo gitlogo32
>        }
>  }

Hmm. Nothing seems to have happened with this patch yet. Any suggestions on how to bring it to the attention of the git-gui people?

Pat Thoyts· Dec 7, 2011, 14:36 UTC · re: Samuel Bronson · lore

Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.

Samuel Bronson <naesten@gmail.com> writes:
>
>Hmm. Nothing seems to have happened with this patch yet. Any
>suggestions on how to bring it to the attention of the git-gui people?

I got around to checking this with xmingw and it makes sense so it's committed now. Thanks.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

← back to recent threads