git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.

From
Samuel Bronson <naesten@gmail.com>
Date
Nov 30, 2011, 00:02 UTC
Message-ID
<CAJYzjmcsGQ8xxmOEvDCZGyT5e=gKkjC7fDxdcbNg4FZRddERpw@mail.gmail.com>
In-Reply-To
<1321640015-6663-1-git-send-email-naesten@gmail.com>
On Fri, Nov 18, 2011 at 1:13 PM, Samuel Bronson <naesten@gmail.com> wrote:
Show 24 quoted lines
> It would be better if the 32x32 icon was equivalent to the one used on
> Windows (in git-gui.ico), but I'm not sure how that would best be done,
> so I copied this code from gitk instead.
> ---
>  git-gui.sh |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index c190cbe..9d01039 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -729,7 +729,12 @@ if {[is_Windows]} {
>                gitlogo put gray26  -to  5 15 11 16
>                gitlogo redither
>
> -               wm iconphoto . -default gitlogo
> +               # TODO: should use something equivalent to the 32x32 image in
> +               # the .ico file
> +               image create photo gitlogo32    -width 32 -height 32
> +               gitlogo32 copy gitlogo -zoom 2 2
> +
> +               wm iconphoto . -default gitlogo gitlogo32
>        }
>  }

Hmm. Nothing seems to have happened with this patch yet. Any suggestions on how to bring it to the attention of the git-gui people?

Previous: Samuel BronsonNext: Pat Thoyts
Message 2 of 3 in “git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.”
  1. git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.Samuel Bronson, Nov 18, 2011
  2. Samuel BronsonNov 30, 2011
  3. Pat ThoytsDec 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.