# [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming. 3 messages from 2011-11-18 to 2011-12-07. Participants: Samuel Bronson, Pat Thoyts. Thread: https://gitlist.dev/t/28975 ## Samuel Bronson, 2011-11-18 18:13 Subject: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming. Message-ID: <1321640015-6663-1-git-send-email-naesten@gmail.com> URL: https://gitlist.dev/e/1321640015-6663-1-git-send-email-naesten%40gmail.com ``` It would be better if the 32x32 icon was equivalent to the one used on Windows (in git-gui.ico), but I'm not sure how that would best be done, so I copied this code from gitk instead. --- git-gui.sh | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/git-gui.sh b/git-gui.sh index c190cbe..9d01039 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -729,7 +729,12 @@ if {[is_Windows]} { gitlogo put gray26 -to 5 15 11 16 gitlogo redither - wm iconphoto . -default gitlogo + # TODO: should use something equivalent to the 32x32 image in + # the .ico file + image create photo gitlogo32 -width 32 -height 32 + gitlogo32 copy gitlogo -zoom 2 2 + + wm iconphoto . -default gitlogo gitlogo32 } } -- 1.7.6.3 ``` ## Samuel Bronson, 2011-11-30 00:02 Subject: Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming. Message-ID: URL: https://gitlist.dev/e/CAJYzjmcsGQ8xxmOEvDCZGyT5e%3DgKkjC7fDxdcbNg4FZRddERpw%40mail.gmail.com In-Reply-To: <1321640015-6663-1-git-send-email-naesten@gmail.com> ``` On Fri, Nov 18, 2011 at 1:13 PM, Samuel Bronson wrote: > It would be better if the 32x32 icon was equivalent to the one used on > Windows (in git-gui.ico), but I'm not sure how that would best be done, > so I copied this code from gitk instead. > --- >  git-gui.sh |    7 ++++++- >  1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/git-gui.sh b/git-gui.sh > index c190cbe..9d01039 100755 > --- a/git-gui.sh > +++ b/git-gui.sh > @@ -729,7 +729,12 @@ if {[is_Windows]} { >                gitlogo put gray26  -to  5 15 11 16 >                gitlogo redither > > -               wm iconphoto . -default gitlogo > +               # TODO: should use something equivalent to the 32x32 image in > +               # the .ico file > +               image create photo gitlogo32    -width 32 -height 32 > +               gitlogo32 copy gitlogo -zoom 2 2 > + > +               wm iconphoto . -default gitlogo gitlogo32 >        } >  } Hmm. Nothing seems to have happened with this patch yet. Any suggestions on how to bring it to the attention of the git-gui people? ``` ## Pat Thoyts, 2011-12-07 14:36 Subject: Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming. Message-ID: <877h2878ju.fsf@fox.patthoyts.tk> URL: https://gitlist.dev/e/877h2878ju.fsf%40fox.patthoyts.tk In-Reply-To: ``` Samuel Bronson writes: > >Hmm. Nothing seems to have happened with this patch yet. Any >suggestions on how to bring it to the attention of the git-gui people? I got around to checking this with xmingw and it makes sense so it's committed now. Thanks. -- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD ```