{"thread":{"id":"28975","subject":"[PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.","startedAt":"2011-11-18T18:13:35Z","lastAt":"2011-12-07T14:36:37Z","messageCount":3,"participants":["Samuel Bronson","Pat Thoyts"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"179711","messageId":"1321640015-6663-1-git-send-email-naesten@gmail.com","threadId":"28975","inReplyTo":null,"subject":"[PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.","fromName":"Samuel Bronson","fromEmail":"naesten@gmail.com","sentAt":"2011-11-18T18:13:35Z","receivedAt":"2011-11-18T18:13:35Z","isPatch":true,"sender":{"key":"naesten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13903?v=4"},"body":"It would be better if the 32x32 icon was equivalent to the one used on\nWindows (in git-gui.ico), but I'm not sure how that would best be done,\nso I copied this code from gitk instead.\n---\n git-gui.sh |    7 ++++++-\n 1 files changed, 6 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex c190cbe..9d01039 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -729,7 +729,12 @@ if {[is_Windows]} {\n \t\tgitlogo put gray26  -to  5 15 11 16\n \t\tgitlogo redither\n \n-\t\twm iconphoto . -default gitlogo\n+\t\t# TODO: should use something equivalent to the 32x32 image in\n+\t\t# the .ico file\n+\t\timage create photo gitlogo32    -width 32 -height 32\n+\t\tgitlogo32 copy gitlogo -zoom 2 2\n+\n+\t\twm iconphoto . -default gitlogo gitlogo32\n \t}\n }\n \n-- \n1.7.6.3\n"},{"id":"180125","messageId":"CAJYzjmcsGQ8xxmOEvDCZGyT5e=gKkjC7fDxdcbNg4FZRddERpw@mail.gmail.com","threadId":"28975","inReplyTo":"1321640015-6663-1-git-send-email-naesten@gmail.com","subject":"Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.","fromName":"Samuel Bronson","fromEmail":"naesten@gmail.com","sentAt":"2011-11-30T00:02:29Z","receivedAt":"2011-11-30T00:02:29Z","isPatch":true,"sender":{"key":"naesten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13903?v=4"},"body":"On Fri, Nov 18, 2011 at 1:13 PM, Samuel Bronson <naesten@gmail.com> wrote:\n> It would be better if the 32x32 icon was equivalent to the one used on\n> Windows (in git-gui.ico), but I'm not sure how that would best be done,\n> so I copied this code from gitk instead.\n> ---\n>  git-gui.sh |    7 ++++++-\n>  1 files changed, 6 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-gui.sh b/git-gui.sh\n> index c190cbe..9d01039 100755\n> --- a/git-gui.sh\n> +++ b/git-gui.sh\n> @@ -729,7 +729,12 @@ if {[is_Windows]} {\n>                gitlogo put gray26  -to  5 15 11 16\n>                gitlogo redither\n>\n> -               wm iconphoto . -default gitlogo\n> +               # TODO: should use something equivalent to the 32x32 image in\n> +               # the .ico file\n> +               image create photo gitlogo32    -width 32 -height 32\n> +               gitlogo32 copy gitlogo -zoom 2 2\n> +\n> +               wm iconphoto . -default gitlogo gitlogo32\n>        }\n>  }\n\nHmm. Nothing seems to have happened with this patch yet. Any\nsuggestions on how to bring it to the attention of the git-gui people?\n"},{"id":"180489","messageId":"877h2878ju.fsf@fox.patthoyts.tk","threadId":"28975","inReplyTo":"CAJYzjmcsGQ8xxmOEvDCZGyT5e=gKkjC7fDxdcbNg4FZRddERpw@mail.gmail.com","subject":"Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2011-12-07T14:36:37Z","receivedAt":"2011-12-07T14:36:37Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Samuel Bronson <naesten@gmail.com> writes:\n>\n>Hmm. Nothing seems to have happened with this patch yet. Any\n>suggestions on how to bring it to the attention of the git-gui people?\n\nI got around to checking this with xmingw and it makes sense so it's\ncommitted now.\nThanks.\n-- \nPat Thoyts                            http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD\n"}]}