threads / patch / 28257

patcht3903: fix misquoted rev-parse invocation

Subject: [PATCH] t3903: fix misquoted rev-parse invocation

## tl;dr

3 messages between Aug 30, 2011 and Aug 30, 2011. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Thomas Rast· Aug 30, 2011, 00:06 UTC · lore

!"git ..." hopefully always succeeds because "git ..." is not the name of any executable. However, that's not what was intended. Unquote it, and while we're at it, also replace ! with test_must_fail since it is a call to git.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
I kind of wonder how many bogus tests we have...
 t/t3903-stash.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to t/t3903-stash.sh +1 −1
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 7197aae..fcdb182 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -542,7 +542,7 @@ test_expect_success 'ref with non-existent reflog' '
 	echo bar6 > file2 &&
 	git add file2 &&
 	git stash &&
-	! "git rev-parse --quiet --verify does-not-exist" &&
+	test_must_fail git rev-parse --quiet --verify does-not-exist &&
 	test_must_fail git stash drop does-not-exist &&
 	test_must_fail git stash drop does-not-exist@{0} &&
 	test_must_fail git stash pop does-not-exist &&

-- 
1.7.7.rc0.370.gdcae57
Jon Seymour· Aug 30, 2011, 01:52 UTC · re: Thomas Rast · lore

Re: [PATCH] t3903: fix misquoted rev-parse invocation

On Tue, Aug 30, 2011 at 10:06 AM, Thomas Rast <trast@student.ethz.ch> wrote:
Show 8 quoted lines
>
> !"git ..." hopefully always succeeds because "git ..." is not the name
> of any executable.  However, that's not what was intended.  Unquote
> it, and while we're at it, also replace ! with test_must_fail since it
> is a call to git.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
Oops.
Acked-by: Jon Seymour <jon.seymour@gmail.com>
| Apologies for resend, didn't realise my gmail was sending in rich text.
jon.

← back to recent threads