git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t3903: fix misquoted rev-parse invocation

From
Thomas Rast <trast@student.ethz.ch>
Date
Aug 30, 2011, 00:06 UTC
Message-ID
<fa41d38f9297ca14b61e05033c9d1b5f5a778263.1314662636.git.trast@student.ethz.ch>

!"git ..." hopefully always succeeds because "git ..." is not the name of any executable. However, that's not what was intended. Unquote it, and while we're at it, also replace ! with test_must_fail since it is a call to git.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
I kind of wonder how many bogus tests we have...
 t/t3903-stash.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 7197aae..fcdb182 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -542,7 +542,7 @@ test_expect_success 'ref with non-existent reflog' '
 	echo bar6 > file2 &&
 	git add file2 &&
 	git stash &&
-	! "git rev-parse --quiet --verify does-not-exist" &&
+	test_must_fail git rev-parse --quiet --verify does-not-exist &&
 	test_must_fail git stash drop does-not-exist &&
 	test_must_fail git stash drop does-not-exist@{0} &&
 	test_must_fail git stash pop does-not-exist &&
-- 
1.7.7.rc0.370.gdcae57
Next: Jon Seymour
Message 1 of 3 in “t3903: fix misquoted rev-parse invocation”
  1. t3903: fix misquoted rev-parse invocationThomas Rast, Aug 30, 2011
  2. Jon SeymourAug 30, 2011
  3. Junio C HamanoAug 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.