# [PATCH] t3903: fix misquoted rev-parse invocation 3 messages from 2011-08-30 to 2011-08-30. Participants: Thomas Rast, Jon Seymour, Junio C Hamano. Thread: https://gitlist.dev/t/28257 ## Thomas Rast, 2011-08-30 00:06 Subject: [PATCH] t3903: fix misquoted rev-parse invocation Message-ID: URL: https://gitlist.dev/e/fa41d38f9297ca14b61e05033c9d1b5f5a778263.1314662636.git.trast%40student.ethz.ch ``` !"git ..." hopefully always succeeds because "git ..." is not the name of any executable. However, that's not what was intended. Unquote it, and while we're at it, also replace ! with test_must_fail since it is a call to git. Signed-off-by: Thomas Rast --- I kind of wonder how many bogus tests we have... t/t3903-stash.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index 7197aae..fcdb182 100755 --- a/t/t3903-stash.sh +++ b/t/t3903-stash.sh @@ -542,7 +542,7 @@ test_expect_success 'ref with non-existent reflog' ' echo bar6 > file2 && git add file2 && git stash && - ! "git rev-parse --quiet --verify does-not-exist" && + test_must_fail git rev-parse --quiet --verify does-not-exist && test_must_fail git stash drop does-not-exist && test_must_fail git stash drop does-not-exist@{0} && test_must_fail git stash pop does-not-exist && -- 1.7.7.rc0.370.gdcae57 ``` ## Jon Seymour, 2011-08-30 01:52 Subject: Re: [PATCH] t3903: fix misquoted rev-parse invocation Message-ID: URL: https://gitlist.dev/e/CAH3AnrophV%3Dbi%2B70B8EnfZpBQXVbEAJ9nSo9UbZ2svDNre9W%3DA%40mail.gmail.com In-Reply-To: ``` On Tue, Aug 30, 2011 at 10:06 AM, Thomas Rast wrote: > > !"git ..." hopefully always succeeds because "git ..." is not the name > of any executable.  However, that's not what was intended.  Unquote > it, and while we're at it, also replace ! with test_must_fail since it > is a call to git. > > Signed-off-by: Thomas Rast > --- Oops. Acked-by: Jon Seymour | Apologies for resend, didn't realise my gmail was sending in rich text. jon. ``` ## Junio C Hamano, 2011-08-30 18:03 Subject: Re: [PATCH] t3903: fix misquoted rev-parse invocation Message-ID: <7vobz622v3.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vobz622v3.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Thanks, both. ```