{"thread":{"id":"28257","subject":"[PATCH] t3903: fix misquoted rev-parse invocation","startedAt":"2011-08-30T00:06:07Z","lastAt":"2011-08-30T18:03:44Z","messageCount":3,"participants":["Thomas Rast","Jon Seymour","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"174525","messageId":"fa41d38f9297ca14b61e05033c9d1b5f5a778263.1314662636.git.trast@student.ethz.ch","threadId":"28257","inReplyTo":null,"subject":"[PATCH] t3903: fix misquoted rev-parse invocation","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2011-08-30T00:06:07Z","receivedAt":"2011-08-30T00:06:07Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"!\"git ...\" hopefully always succeeds because \"git ...\" is not the name\nof any executable.  However, that's not what was intended.  Unquote\nit, and while we're at it, also replace ! with test_must_fail since it\nis a call to git.\n\nSigned-off-by: Thomas Rast <trast@student.ethz.ch>\n---\n\nI kind of wonder how many bogus tests we have...\n\n t/t3903-stash.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t3903-stash.sh b/t/t3903-stash.sh\nindex 7197aae..fcdb182 100755\n--- a/t/t3903-stash.sh\n+++ b/t/t3903-stash.sh\n@@ -542,7 +542,7 @@ test_expect_success 'ref with non-existent reflog' '\n \techo bar6 > file2 &&\n \tgit add file2 &&\n \tgit stash &&\n-\t! \"git rev-parse --quiet --verify does-not-exist\" &&\n+\ttest_must_fail git rev-parse --quiet --verify does-not-exist &&\n \ttest_must_fail git stash drop does-not-exist &&\n \ttest_must_fail git stash drop does-not-exist@{0} &&\n \ttest_must_fail git stash pop does-not-exist &&\n-- \n1.7.7.rc0.370.gdcae57\n"},{"id":"174530","messageId":"CAH3AnrophV=bi+70B8EnfZpBQXVbEAJ9nSo9UbZ2svDNre9W=A@mail.gmail.com","threadId":"28257","inReplyTo":"fa41d38f9297ca14b61e05033c9d1b5f5a778263.1314662636.git.trast@student.ethz.ch","subject":"Re: [PATCH] t3903: fix misquoted rev-parse invocation","fromName":"Jon Seymour","fromEmail":"jon.seymour@gmail.com","sentAt":"2011-08-30T01:52:53Z","receivedAt":"2011-08-30T01:52:53Z","isPatch":true,"sender":{"key":"jon.seymour@gmail.com","avatar":"https://avatars.githubusercontent.com/u/207131?v=4"},"body":"On Tue, Aug 30, 2011 at 10:06 AM, Thomas Rast <trast@student.ethz.ch> wrote:\n>\n> !\"git ...\" hopefully always succeeds because \"git ...\" is not the name\n> of any executable.  However, that's not what was intended.  Unquote\n> it, and while we're at it, also replace ! with test_must_fail since it\n> is a call to git.\n>\n> Signed-off-by: Thomas Rast <trast@student.ethz.ch>\n> ---\n\nOops.\n\nAcked-by: Jon Seymour <jon.seymour@gmail.com>\n\n| Apologies for resend, didn't realise my gmail was sending in rich text.\n\njon.\n"},{"id":"174569","messageId":"7vobz622v3.fsf@alter.siamese.dyndns.org","threadId":"28257","inReplyTo":"CAH3AnrophV=bi+70B8EnfZpBQXVbEAJ9nSo9UbZ2svDNre9W=A@mail.gmail.com","subject":"Re: [PATCH] t3903: fix misquoted rev-parse invocation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-08-30T18:03:44Z","receivedAt":"2011-08-30T18:03:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, both.\n"}]}