threads / patch / 28189

patchDo not use C++-style comments

Subject: [PATCH] Do not use C++-style comments

## tl;dr

2 messages between Aug 22, 2011 and Aug 22, 2011. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Michael Haggerty· Aug 22, 2011, 10:33 UTC · lore

Detected by "gcc -std=iso9899:1990 ...". This patch applies against "maint".

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 notes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to notes.c +1 −1

diff --git a/notes.c b/notes.c
index f6ce848..93e9868 100644
--- a/notes.c
+++ b/notes.c
@@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const unsigned char *object_sha1)
 	hashcpy(l.key_sha1, object_sha1);
 	hashclr(l.val_sha1);
 	note_tree_remove(t, t->root, 0, &l);
-	if (is_null_sha1(l.val_sha1)) // no note was removed
+	if (is_null_sha1(l.val_sha1)) /* no note was removed */
 		return 1;
 	t->dirty = 1;
 	return 0;

-- 
1.7.6.8.gd2879

Johan Herland· Aug 22, 2011, 11:55 UTC · re: Michael Haggerty · lore

Re: [PATCH] Do not use C++-style comments

On Monday 22. August 2011, Michael Haggerty wrote:

Show 18 quoted lines

> Detected by "gcc -std=iso9899:1990 ...".  This patch applies against
> "maint".
> 
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>  notes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/notes.c b/notes.c
> index f6ce848..93e9868 100644
> --- a/notes.c
> +++ b/notes.c
> @@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const
> unsigned char *object_sha1) hashcpy(l.key_sha1, object_sha1);
>  	hashclr(l.val_sha1);
>  	note_tree_remove(t, t->root, 0, &l);
> -	if (is_null_sha1(l.val_sha1)) // no note was removed
> +	if (is_null_sha1(l.val_sha1)) /* no note was removed */

ACK!

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net