{"thread":{"id":"28189","subject":"[PATCH] Do not use C++-style comments","startedAt":"2011-08-22T10:33:52Z","lastAt":"2011-08-22T11:55:51Z","messageCount":2,"participants":["Michael Haggerty","Johan Herland"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"174008","messageId":"1314009232-6194-1-git-send-email-mhagger@alum.mit.edu","threadId":"28189","inReplyTo":null,"subject":"[PATCH] Do not use C++-style comments","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2011-08-22T10:33:52Z","receivedAt":"2011-08-22T10:33:52Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"Detected by \"gcc -std=iso9899:1990 ...\".  This patch applies against\n\"maint\".\n\nSigned-off-by: Michael Haggerty <mhagger@alum.mit.edu>\n---\n notes.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/notes.c b/notes.c\nindex f6ce848..93e9868 100644\n--- a/notes.c\n+++ b/notes.c\n@@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const unsigned char *object_sha1)\n \thashcpy(l.key_sha1, object_sha1);\n \thashclr(l.val_sha1);\n \tnote_tree_remove(t, t->root, 0, &l);\n-\tif (is_null_sha1(l.val_sha1)) // no note was removed\n+\tif (is_null_sha1(l.val_sha1)) /* no note was removed */\n \t\treturn 1;\n \tt->dirty = 1;\n \treturn 0;\n-- \n1.7.6.8.gd2879\n"},{"id":"174009","messageId":"201108221355.52269.johan@herland.net","threadId":"28189","inReplyTo":"1314009232-6194-1-git-send-email-mhagger@alum.mit.edu","subject":"Re: [PATCH] Do not use C++-style comments","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2011-08-22T11:55:51Z","receivedAt":"2011-08-22T11:55:51Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"On Monday 22. August 2011, Michael Haggerty wrote:\n> Detected by \"gcc -std=iso9899:1990 ...\".  This patch applies against\n> \"maint\".\n> \n> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>\n> ---\n>  notes.c |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/notes.c b/notes.c\n> index f6ce848..93e9868 100644\n> --- a/notes.c\n> +++ b/notes.c\n> @@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const\n> unsigned char *object_sha1) hashcpy(l.key_sha1, object_sha1);\n>  \thashclr(l.val_sha1);\n>  \tnote_tree_remove(t, t->root, 0, &l);\n> -\tif (is_null_sha1(l.val_sha1)) // no note was removed\n> +\tif (is_null_sha1(l.val_sha1)) /* no note was removed */\n\nACK!\n\n\n...Johan\n\n-- \nJohan Herland, <johan@herland.net>\nwww.herland.net\n"}]}