git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Do not use C++-style comments

From
Johan Herland <johan@herland.net>
Date
Aug 22, 2011, 11:55 UTC
Message-ID
<201108221355.52269.johan@herland.net>
In-Reply-To
<1314009232-6194-1-git-send-email-mhagger@alum.mit.edu>
On Monday 22. August 2011, Michael Haggerty wrote:
Show 18 quoted lines
> Detected by "gcc -std=iso9899:1990 ...".  This patch applies against
> "maint".
> 
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>  notes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/notes.c b/notes.c
> index f6ce848..93e9868 100644
> --- a/notes.c
> +++ b/notes.c
> @@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const
> unsigned char *object_sha1) hashcpy(l.key_sha1, object_sha1);
>  	hashclr(l.val_sha1);
>  	note_tree_remove(t, t->root, 0, &l);
> -	if (is_null_sha1(l.val_sha1)) // no note was removed
> +	if (is_null_sha1(l.val_sha1)) /* no note was removed */
ACK!
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Michael Haggerty
Message 2 of 2 in “Do not use C++-style comments”
  1. Do not use C++-style commentsMichael Haggerty, Aug 22, 2011
  2. Johan HerlandAug 22, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.