# [PATCH] Do not use C++-style comments 2 messages from 2011-08-22 to 2011-08-22. Participants: Michael Haggerty, Johan Herland. Thread: https://gitlist.dev/t/28189 ## Michael Haggerty, 2011-08-22 10:33 Subject: [PATCH] Do not use C++-style comments Message-ID: <1314009232-6194-1-git-send-email-mhagger@alum.mit.edu> URL: https://gitlist.dev/e/1314009232-6194-1-git-send-email-mhagger%40alum.mit.edu ``` Detected by "gcc -std=iso9899:1990 ...". This patch applies against "maint". Signed-off-by: Michael Haggerty --- notes.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notes.c b/notes.c index f6ce848..93e9868 100644 --- a/notes.c +++ b/notes.c @@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const unsigned char *object_sha1) hashcpy(l.key_sha1, object_sha1); hashclr(l.val_sha1); note_tree_remove(t, t->root, 0, &l); - if (is_null_sha1(l.val_sha1)) // no note was removed + if (is_null_sha1(l.val_sha1)) /* no note was removed */ return 1; t->dirty = 1; return 0; -- 1.7.6.8.gd2879 ``` ## Johan Herland, 2011-08-22 11:55 Subject: Re: [PATCH] Do not use C++-style comments Message-ID: <201108221355.52269.johan@herland.net> URL: https://gitlist.dev/e/201108221355.52269.johan%40herland.net In-Reply-To: <1314009232-6194-1-git-send-email-mhagger@alum.mit.edu> ``` On Monday 22. August 2011, Michael Haggerty wrote: > Detected by "gcc -std=iso9899:1990 ...". This patch applies against > "maint". > > Signed-off-by: Michael Haggerty > --- > notes.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/notes.c b/notes.c > index f6ce848..93e9868 100644 > --- a/notes.c > +++ b/notes.c > @@ -1105,7 +1105,7 @@ int remove_note(struct notes_tree *t, const > unsigned char *object_sha1) hashcpy(l.key_sha1, object_sha1); > hashclr(l.val_sha1); > note_tree_remove(t, t->root, 0, &l); > - if (is_null_sha1(l.val_sha1)) // no note was removed > + if (is_null_sha1(l.val_sha1)) /* no note was removed */ ACK! ...Johan -- Johan Herland, www.herland.net ```