threads / patch / 22385

patchgit_connect: use use_shell instead of explicit "sh", "-c"

Subject: [PATCH] git_connect: use use_shell instead of explicit "sh", "-c"

## tl;dr

2 messages between Jan 25, 2010 and Jan 25, 2010. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Johannes Sixt· Jan 25, 2010, 12:32 UTC · lore

From: Johannes Sixt <j6t@kdbg.org>

This is a followup to ac0ba18 (run-command: convert simple callsites to use_shell, 2009-12-30), for consistency.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 Jeff,

 is there a reason that this was not part of the original patch?

 -- Hannes

 connect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Show changes to connect.c +1 −2

diff --git a/connect.c b/connect.c
index db965c9..3a12562 100644
--- a/connect.c
+++ b/connect.c
@@ -613,8 +613,7 @@ struct child_process *git_connect(int fd[2], const
char *url_orig,
 			NULL
 		};
 		conn->env = env;
-		*arg++ = "sh";
-		*arg++ = "-c";
+		conn->use_shell = 1;
 	}
 	*arg++ = cmd.buf;
 	*arg = NULL;

-- 
1.7.0.rc0.39.g31c5d

Jeff King· Jan 25, 2010, 13:01 UTC · re: Johannes Sixt · lore

Re: [PATCH] git_connect: use use_shell instead of explicit "sh", "-c"

On Mon, Jan 25, 2010 at 01:32:44PM +0100, Johannes Sixt wrote:

Show 8 quoted lines

> This is a followup to ac0ba18 (run-command: convert simple callsites to
> use_shell, 2009-12-30), for consistency.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  Jeff,
> 
>  is there a reason that this was not part of the original patch?

No, I must have just missed it (I don't remember omitting it for a particular reason at the time, and after looking at it now, it looks sane to me).

After this, git grep '"sh"' turns up only two uses: one in the run-command code use_shell code path, and the other in builtin-help.c. The one in builtin-help is hard to change, as it relies on direct exec instead of run-command.

-Peff