git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git_connect: use use_shell instead of explicit "sh", "-c"

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Jan 25, 2010, 12:32 UTC
Message-ID
<4B5D8F6C.1040407@viscovery.net>
From: Johannes Sixt <j6t@kdbg.org>

This is a followup to ac0ba18 (run-command: convert simple callsites to use_shell, 2009-12-30), for consistency.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 Jeff,
 is there a reason that this was not part of the original patch?
 -- Hannes
 connect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/connect.c b/connect.c
index db965c9..3a12562 100644
--- a/connect.c
+++ b/connect.c
@@ -613,8 +613,7 @@ struct child_process *git_connect(int fd[2], const
char *url_orig,
 			NULL
 		};
 		conn->env = env;
-		*arg++ = "sh";
-		*arg++ = "-c";
+		conn->use_shell = 1;
 	}
 	*arg++ = cmd.buf;
 	*arg = NULL;
-- 
1.7.0.rc0.39.g31c5d
Next: Jeff King
Message 1 of 2 in “git_connect: use use_shell instead of explicit "sh", "-c"”
  1. git_connect: use use_shell instead of explicit "sh", "-c"Johannes Sixt, Jan 25, 2010
  2. Jeff KingJan 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.