# [PATCH] git_connect: use use_shell instead of explicit "sh", "-c" 2 messages from 2010-01-25 to 2010-01-25. Participants: Johannes Sixt, Jeff King. Thread: https://gitlist.dev/t/22385 ## Johannes Sixt, 2010-01-25 12:32 Subject: [PATCH] git_connect: use use_shell instead of explicit "sh", "-c" Message-ID: <4B5D8F6C.1040407@viscovery.net> URL: https://gitlist.dev/e/4B5D8F6C.1040407%40viscovery.net ``` From: Johannes Sixt This is a followup to ac0ba18 (run-command: convert simple callsites to use_shell, 2009-12-30), for consistency. Signed-off-by: Johannes Sixt --- Jeff, is there a reason that this was not part of the original patch? -- Hannes connect.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/connect.c b/connect.c index db965c9..3a12562 100644 --- a/connect.c +++ b/connect.c @@ -613,8 +613,7 @@ struct child_process *git_connect(int fd[2], const char *url_orig, NULL }; conn->env = env; - *arg++ = "sh"; - *arg++ = "-c"; + conn->use_shell = 1; } *arg++ = cmd.buf; *arg = NULL; -- 1.7.0.rc0.39.g31c5d ``` ## Jeff King, 2010-01-25 13:01 Subject: Re: [PATCH] git_connect: use use_shell instead of explicit "sh", "-c" Message-ID: <20100125130125.GA10036@coredump.intra.peff.net> URL: https://gitlist.dev/e/20100125130125.GA10036%40coredump.intra.peff.net In-Reply-To: <4B5D8F6C.1040407@viscovery.net> ``` On Mon, Jan 25, 2010 at 01:32:44PM +0100, Johannes Sixt wrote: > This is a followup to ac0ba18 (run-command: convert simple callsites to > use_shell, 2009-12-30), for consistency. > > Signed-off-by: Johannes Sixt > --- > Jeff, > > is there a reason that this was not part of the original patch? No, I must have just missed it (I don't remember omitting it for a particular reason at the time, and after looking at it now, it looks sane to me). After this, git grep '"sh"' turns up only two uses: one in the run-command code use_shell code path, and the other in builtin-help.c. The one in builtin-help is hard to change, as it relies on direct exec instead of run-command. -Peff ```