git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git_connect: use use_shell instead of explicit "sh", "-c"

From
Jeff King <peff@peff.net>
Date
Jan 25, 2010, 13:01 UTC
Message-ID
<20100125130125.GA10036@coredump.intra.peff.net>
In-Reply-To
<4B5D8F6C.1040407@viscovery.net>
On Mon, Jan 25, 2010 at 01:32:44PM +0100, Johannes Sixt wrote:
Show 8 quoted lines
> This is a followup to ac0ba18 (run-command: convert simple callsites to
> use_shell, 2009-12-30), for consistency.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  Jeff,
> 
>  is there a reason that this was not part of the original patch?

No, I must have just missed it (I don't remember omitting it for a particular reason at the time, and after looking at it now, it looks sane to me).

After this, git grep '"sh"' turns up only two uses: one in the run-command code use_shell code path, and the other in builtin-help.c. The one in builtin-help is hard to change, as it relies on direct exec instead of run-command.

-Peff
Previous: Johannes Sixt
Message 2 of 2 in “git_connect: use use_shell instead of explicit "sh", "-c"”
  1. git_connect: use use_shell instead of explicit "sh", "-c"Johannes Sixt, Jan 25, 2010
  2. Jeff KingJan 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.