threads / patch / 19067

patchRe: [PATCH] Add semicolon to curly brace group in main Makefile

Subject: Re: [PATCH] Add semicolon to curly brace group in main Makefile

## tl;dr

2 messages between Apr 27, 2009 and Apr 27, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Mark Drago· Apr 27, 2009, 02:36 UTC · lore

[PATCH] Add semicolon to curly brace group in main Makefile

This semicolon is technically required by bash and indeed caused a syntax error on a system that I came across running, an admittedly very old, bash-2.04.0.

http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping

Signed-off-by: Mark Drago <markdrago@gmail.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index 5c8e83a..f006d2c 100644
--- a/Makefile
+++ b/Makefile
@@ -1557,7 +1557,7 @@ endif
 		ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \
 		ln -s "git-add$X" "$$execdir/$$p" 2>/dev/null || \
 		cp "$$execdir/git-add$X" "$$execdir/$$p" || exit; \
-	  done } && \
+	  done; } && \
 	./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
 
 install-doc:

-- 
1.5.6.3

Junio C Hamano· Apr 27, 2009, 06:21 UTC · re: Mark Drago · lore

Mark Drago <markdrago@gmail.com> writes:

Show 6 quoted lines

> This semicolon is technically required by bash and indeed caused a syntax error
> on a system that I came across running, an admittedly very old, bash-2.04.0.
>
> http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping
>
> Signed-off-by: Mark Drago <markdrago@gmail.com>

Thanks; it is not specific to bash. At the end of compound_list before the Rbrace at the end of brace_group, a separator is required.