git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Add semicolon to curly brace group in main Makefile

From
Mark Drago <markdrago@gmail.com>
Date
Apr 27, 2009, 02:36 UTC
Message-ID
<1240799808-7340-1-git-send-email-markdrago@gmail.com>

This semicolon is technically required by bash and indeed caused a syntax error on a system that I came across running, an admittedly very old, bash-2.04.0.

http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping
Signed-off-by: Mark Drago <markdrago@gmail.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 5c8e83a..f006d2c 100644
--- a/Makefile
+++ b/Makefile
@@ -1557,7 +1557,7 @@ endif
 		ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \
 		ln -s "git-add$X" "$$execdir/$$p" 2>/dev/null || \
 		cp "$$execdir/git-add$X" "$$execdir/$$p" || exit; \
-	  done } && \
+	  done; } && \
 	./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
 
 install-doc:
-- 
1.5.6.3
Next: Junio C Hamano
Message 1 of 2 in “Add semicolon to curly brace group in main Makefile”
  1. Add semicolon to curly brace group in main MakefileMark Drago, Apr 27, 2009
  2. Junio C HamanoApr 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.