{"thread":{"id":"19067","subject":"Re: [PATCH] Add semicolon to curly brace group in main Makefile","startedAt":"2009-04-27T02:36:48Z","lastAt":"2009-04-27T06:21:44Z","messageCount":2,"participants":["Junio C Hamano","Mark Drago"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"112349","messageId":"1240799808-7340-1-git-send-email-markdrago@gmail.com","threadId":"19067","inReplyTo":null,"subject":"[PATCH] Add semicolon to curly brace group in main Makefile","fromName":"Mark Drago","fromEmail":"markdrago@gmail.com","sentAt":"2009-04-27T02:36:48Z","receivedAt":"2009-04-27T02:36:48Z","isPatch":true,"sender":{"key":"markdrago@gmail.com","avatar":"https://gravatar.com/avatar/44978f3f99c6ac0e3f95f9a6be0846a07005d7ce1fd17a28d175f745b4401e6d?d=mp&s=160"},"body":"This semicolon is technically required by bash and indeed caused a syntax error\non a system that I came across running, an admittedly very old, bash-2.04.0.\n\nhttp://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping\n\nSigned-off-by: Mark Drago <markdrago@gmail.com>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 5c8e83a..f006d2c 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1557,7 +1557,7 @@ endif\n \t\tln \"$$execdir/git-add$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n \t\tln -s \"git-add$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n \t\tcp \"$$execdir/git-add$X\" \"$$execdir/$$p\" || exit; \\\n-\t  done } && \\\n+\t  done; } && \\\n \t./check_bindir \"z$$bindir\" \"z$$execdir\" \"$$bindir/git-add$X\"\n \n install-doc:\n-- \n1.5.6.3\n"},{"id":"112346","messageId":"7vhc0aaa6f.fsf@gitster.siamese.dyndns.org","threadId":"19067","inReplyTo":"1240799808-7340-1-git-send-email-markdrago@gmail.com","subject":"Re: [PATCH] Add semicolon to curly brace group in main Makefile","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-04-27T06:21:44Z","receivedAt":"2009-04-27T06:21:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mark Drago <markdrago@gmail.com> writes:\n\n> This semicolon is technically required by bash and indeed caused a syntax error\n> on a system that I came across running, an admittedly very old, bash-2.04.0.\n>\n> http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping\n>\n> Signed-off-by: Mark Drago <markdrago@gmail.com>\n\nThanks; it is not specific to bash.  At the end of compound_list before\nthe Rbrace at the end of brace_group, a separator is required.\n"}]}