# Re: [PATCH] Add semicolon to curly brace group in main Makefile 2 messages from 2009-04-27 to 2009-04-27. Participants: Junio C Hamano, Mark Drago. Thread: https://gitlist.dev/t/19067 ## Mark Drago, 2009-04-27 02:36 Subject: [PATCH] Add semicolon to curly brace group in main Makefile Message-ID: <1240799808-7340-1-git-send-email-markdrago@gmail.com> URL: https://gitlist.dev/e/1240799808-7340-1-git-send-email-markdrago%40gmail.com ``` This semicolon is technically required by bash and indeed caused a syntax error on a system that I came across running, an admittedly very old, bash-2.04.0. http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping Signed-off-by: Mark Drago --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 5c8e83a..f006d2c 100644 --- a/Makefile +++ b/Makefile @@ -1557,7 +1557,7 @@ endif ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \ ln -s "git-add$X" "$$execdir/$$p" 2>/dev/null || \ cp "$$execdir/git-add$X" "$$execdir/$$p" || exit; \ - done } && \ + done; } && \ ./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X" install-doc: -- 1.5.6.3 ``` ## Junio C Hamano, 2009-04-27 06:21 Subject: Re: [PATCH] Add semicolon to curly brace group in main Makefile Message-ID: <7vhc0aaa6f.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vhc0aaa6f.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1240799808-7340-1-git-send-email-markdrago@gmail.com> ``` Mark Drago writes: > This semicolon is technically required by bash and indeed caused a syntax error > on a system that I came across running, an admittedly very old, bash-2.04.0. > > http://www.gnu.org/software/bash/manual/bashref.html#Command-Grouping > > Signed-off-by: Mark Drago Thanks; it is not specific to bash. At the end of compound_list before the Rbrace at the end of brace_group, a separator is required. ```