threads / discuss / 1893

Make "gitk" work with time-based arguments

Subject: Make "gitk" work with time-based arguments

## tl;dr

One message between Sep 20, 2005 and Sep 20, 2005.

replies: 0people: 1as markdown or json

Linus Torvalds· Sep 20, 2005, 21:16 UTC · lore

gitk wasn't able to take to take advantage of the new date parsing of git-rev-parse, because it didn't pass on arguments that needed quoting properly.

This is the black magic incantation necessary to make tcl do this right.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -33,8 +33,8 @@ proc getcommits {rargs} {
     set nextupdate [expr $startmsecs + 100]
     set ncmupdate 1
     if [catch {
-	set parse_args [concat --default HEAD $rargs]
-	set parsed_args [split [eval exec git-rev-parse $parse_args] "\n"]
+	set parse_cmd [concat git-rev-parse --default HEAD $rargs]
+	set parsed_args [split [eval exec $parse_cmd] "\n"]
     }] {
 	# if git-rev-parse failed for some reason...
 	if {$rargs == {}} {

← back to recent threads