# Make "gitk" work with time-based arguments

1 messages from 2005-09-20 to 2005-09-20. Participants: Linus Torvalds.
Thread: https://gitlist.dev/t/1893

## Linus Torvalds, 2005-09-20 21:16

Subject: Make "gitk" work with time-based arguments
Message-ID: <Pine.LNX.4.58.0509201413300.2553@g5.osdl.org>
URL: https://gitlist.dev/e/Pine.LNX.4.58.0509201413300.2553%40g5.osdl.org

```

gitk wasn't able to take to take advantage of the new date parsing of 
git-rev-parse, because it didn't pass on arguments that needed quoting 
properly.

This is the black magic incantation necessary to make tcl do this right.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -33,8 +33,8 @@ proc getcommits {rargs} {
     set nextupdate [expr $startmsecs + 100]
     set ncmupdate 1
     if [catch {
-	set parse_args [concat --default HEAD $rargs]
-	set parsed_args [split [eval exec git-rev-parse $parse_args] "\n"]
+	set parse_cmd [concat git-rev-parse --default HEAD $rargs]
+	set parsed_args [split [eval exec $parse_cmd] "\n"]
     }] {
 	# if git-rev-parse failed for some reason...
 	if {$rargs == {}} {

```